derive: remove darling dependency
#619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not really utilizing it much, and it adds considerably to compile times. The idea of declarative attribute parsers is a good one, however we're not at the stage where it's worth the extra overhead. The replacement code isn't great and misses a few key cases, but really all of the component-related code is in need of an overhaul and can perhaps be replaced with some existing well-maintained 3rd party library for dependency injection.
Shella
approved these changes
Jan 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not really utilizing it much, and it adds considerably to compile times.
The idea of declarative attribute parsers is a good one, however we're not at the stage where it's worth the extra overhead.
The replacement code isn't great and misses a few key cases, but really all of the component-related code is in need of an overhaul and can perhaps be replaced with some existing well-maintained 3rd party library for dependency injection.