generator: Add config filename boilerplate to template (closes #80) #82
Conversation
This adds boilerplate which includes the config filename, checks if it exists, and if not, ignores it. Including this check in the boilerplate, and the explanatory comments around it, should hopefully be sufficient to address questions in #80.
| // Check if the config file exists, and if it does not, ignore it. | ||
| // If you'd like for a missing configuration file to be a hard error | ||
| // instead, always return `Some(CONFIG_FILE)` here. | ||
| let filename = PathBuf::from(CONFIG_FILE); |
There was a problem hiding this comment.
Maybe I'm missing something, but isn't this going to just try to open myapp.toml, without respect to where that config file should actually be located (e.g., /home/user/.config/, etc)?
There was a problem hiding this comment.
Yeah, as configured this will only look in CWD, which is agnostic to the questions you're asking, the answers to which will depend if the application in question is intended to be installed systemwide (several of ours are), or if you're using XDG directories as you suggest, or if you don't want to use XDG directories.
Getting a bit more specific is tricky, and in particular crates like dirs have a large number of transitive dependencies I'd like to avoid including by default (for my apps that do keep configs in the user's home directory, I'd rather just rely on the home crate).
This is definitely something that could use a bit more fleshing out though, and ideally unified with Abscissa's other path-handling functionality
This adds boilerplate which includes the config filename, checks if it exists, and if not, ignores it.
Including this check in the boilerplate, and the explanatory comments around it, should hopefully be sufficient to address questions in #80.