generator: Remove hashbrown dependency #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handlebars 2.0.0 -> 2.0.1 upgraded `hashbrown` versions from 0.4 to 0.5 and in doing so broke the Abscissa v0.1 release, which now has an older incompatible v0.4. I've opened an upstream issue about this here: sunng87/handlebars-rust#279 To avoid this in the future, this change removes the external dependency. The implementation is a bit hacky, but gets the job done.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handlebars 2.0.0 -> 2.0.1 upgraded
hashbrownversions from 0.4 to 0.5 and in doing so broke the Abscissa v0.1 release, which now has an older incompatible v0.4. I've opened an upstream issue about this here:sunng87/handlebars-rust#279
To avoid this in the future, this change removes the external dependency. The implementation is a bit hacky, but gets the job done.