Bech32 "preview" implementation #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merges the iq-bech32 crate into subtle-encoding. The current implementation is NOT constant time, and is gated under the "bech32-preview" feature with appropriate scare copy for turning it on. This WIP PR shows step 1 of 2 for converting the implementation to constant-time: #71 The Bech32 alphabet also needs a constant time implementation, which can be implemented in a similar manner to the Base64 code (with a lot more "branches" for the Bech32 character mapping).
tarcieri
force-pushed
the
subtle-encoding/bech32-preview
branch
from
5887858
to
a9cbe1f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the
iq-bech32crate intosubtle-encoding.The current implementation is NOT constant time, and is gated under the "bech32-preview" cargo feature with appropriate scare copy for turning it on.
This WIP PR shows step 1 of 2 for converting the implementation to constant-time:
#71
The Bech32 alphabet also needs a constant time implementation, which can be implemented in a similar manner to the Base64 code (with a lot more "branches" for the Bech32 character mapping). I plan on creating an
Accumulatortype which will simplify the implementation (and can also be used for the Base64 and hex impls)