tx_signer: add "JSONRPC" request params; refactor response #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
tx_signer/request-params
branch
from
a982c50
to
71cc1c9
Compare
zmanian
approved these changes
Oct 15, 2020
This commit sends a JSON-serialized body of parameters with each request to a "transaction source" (i.e. oracle): - Chain ID - Arbitrary context string (optional; taken from tmkms config) - Last Tendermint RPC `/status` response - Commit response from last broadcasted transaction This should make it possible for Delphi to detect that an error occured broadcasting the last transaction and skip voting during that period. Additionally it makes a somewhat breaking change to the response format expected from a transaction source: it now (optionally) expects a single transaction, rather than a vec of them. This simplifies the response error handling, and encourages sources to pack more messages into a single transaction rather than using multiple transactions.
tarcieri
force-pushed
the
tx_signer/request-params
branch
from
71cc1c9
to
da246a7
Compare
tarcieri
pushed a commit
to iqlusioninc/delphi
that referenced
this pull request
Oct 15, 2020
Adds support for a JSON-serialized request body, corresponding to the one introduced to the KMS in: iqlusioninc/tmkms#170 So far it just prints out the contents as a `dbg` statement, but this can be used in integration testing to cross-check that the body is being sent and parsed correctly. After confirming that, we can add handling for its contents.
tarcieri
pushed a commit
to iqlusioninc/delphi
that referenced
this pull request
Oct 15, 2020
Adds support for a JSON-serialized request body, corresponding to the one introduced to the KMS in: iqlusioninc/tmkms#170 So far it just prints out the contents as a `dbg` statement, but this can be used in integration testing to cross-check that the body is being sent and parsed correctly. After confirming that, we can add handling for its contents.
tony-iqlusion
added a commit
to iqlusioninc/delphi
that referenced
this pull request
Oct 15, 2020
Adds support for a JSON-serialized request body, corresponding to the one introduced to the KMS in: iqlusioninc/tmkms#170 So far it just prints out the contents as a `dbg` statement, but this can be used in integration testing to cross-check that the body is being sent and parsed correctly. After confirming that, we can add handling for its contents.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sends a JSON-serialized body of parameters with each request to a "transaction source" (i.e. oracle):
/statusresponseThis should make it possible for Delphi to detect that an error occurred broadcasting the last transaction and skip voting during that period.
Additionally it makes a somewhat breaking change to the response format expected from a transaction source: it now (optionally) expects a single transaction, rather than a vec of them. This simplifies the response error handling, and encourages sources to pack more messages into a single transaction rather than using multiple transactions.