Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geospatial tooltip updated #10447

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Geospatial tooltip updated #10447

merged 3 commits into from
Mar 29, 2024

Conversation

jp-tosca
Copy link
Contributor

@jp-tosca jp-tosca commented Mar 28, 2024

What this PR does / why we need it:
"This tooltip in the UI mentions the use of commas instead of decimals points, this is incorrect formatting and will fail against the validation now added for geospatial bounding box validation for geospatial search"

Which issue(s) this PR closes:

Closes #10397

Special notes for your reviewer:

Suggestions on how to test this:
Mouse over the suggestion for this block.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:
Yes, reload the block 馃槃

Additional documentation:

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!
I only added 2-3 words to the sentence in the release note.
I will also comment in the issue, to address some questions from the planning meeting yesterday.

@landreev landreev added the Size: 0.5 A percentage of a sprint. 0.35 hours label Mar 28, 2024
@landreev landreev added this to the 6.2 milestone Mar 28, 2024
@sekmiller sekmiller self-assigned this Mar 29, 2024
@sekmiller sekmiller merged commit 2f6d3aa into develop Mar 29, 2024
2 checks passed
@sekmiller sekmiller deleted the geospatial-tooltip-fix branch March 29, 2024 13:32
@jp-tosca jp-tosca added Size: 3 A percentage of a sprint. 2.1 hours. NIH CAFE Issues related to and/or funded by the NIH CAFE project Type: Bug a defect Feature: Geospatial and removed Size: 0.5 A percentage of a sprint. 0.35 hours labels Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Geospatial NIH CAFE Issues related to and/or funded by the NIH CAFE project Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect
Projects
Status: Done 馃Ч
3 participants