Conversation
landreev
approved these changes
Mar 28, 2024
Contributor
landreev
left a comment
There was a problem hiding this comment.
Looks great, thank you!
I only added 2-3 words to the sentence in the release note.
I will also comment in the issue, to address some questions from the planning meeting yesterday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
"This tooltip in the UI mentions the use of commas instead of decimals points, this is incorrect formatting and will fail against the validation now added for geospatial bounding box validation for geospatial search"
Which issue(s) this PR closes:
Closes #10397
Special notes for your reviewer:
Suggestions on how to test this:
Mouse over the suggestion for this block.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Yes, reload the block 😄
Additional documentation: