Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geospatial Metadata fields not properly indented compared to other fields #6753

Closed
BPeuch opened this issue Mar 20, 2020 · 3 comments · Fixed by #6912
Closed

Geospatial Metadata fields not properly indented compared to other fields #6753

BPeuch opened this issue Mar 20, 2020 · 3 comments · Fixed by #6912

Comments

@BPeuch
Copy link
Contributor

BPeuch commented Mar 20, 2020

Version: 4.19

Hello everybody,

There is a discrepancy in indentation between the fields of Geospatial Metadata and those of Citation Metadata and Social Sciences and Humanities Metadata, as you can see here:

geogindent

The issue occurred in Firefox, Chrome and Opera.

@BPeuch BPeuch added this to Pretty please in Dataverse SODHA (Belgium) Mar 20, 2020
@BPeuch
Copy link
Contributor Author

BPeuch commented Apr 7, 2020

Version: 4.20

Hello everybody,

It looks like the identation problem now also occurs with the Social Sciences and Humanities Metadata box now that we've moved to version 4.20:

probindent

I believe there are now three indentation tabs, one for each metadata box. Maybe this will help detect the origin of the problem?

The issue occurred with Firefox, Chrome and Opera.

@mheppler
Copy link
Contributor

@BPeuch good catch, and thank you for reporting the issue. It appears that the recent layount changes to the metadata on the dataset pg in 4.18 (#6109) missed this label column width inconsistency. With a few minor adjustments to the stylesheet properties, we now have a consistent label column width of 25% because we have a consistent table width of 100%. The varying label column widths was due to varying width of the table. Now that the table is 100% of the panel width, that 25% label column width will hold consistently across all the blocks.

Screen Shot 2020-05-13 at 11 15 02 AM

@BPeuch
Copy link
Contributor Author

BPeuch commented May 18, 2020

Wonderful! Thanks a lot for your feedback, @mheppler, and to everyone else for tackling this issue so quickly.

@BPeuch BPeuch moved this from Pretty please to THE PACT IS SEALED (done) in Dataverse SODHA (Belgium) Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Dataverse SODHA (Belgium)
Solved (thank you!)
Development

Successfully merging a pull request may close this issue.

3 participants