4813 allow duplicate files #6924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
added this to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
djbrooke
moved this from Code Review 🦁
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
sekmiller
moved this from IQSS Team - In Progress 💻
to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
djbrooke
moved this from Code Review 🦁
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
I updated the messaging based on discussion during the Design Meeting. |
sekmiller
moved this from Code Review 🦁
to QA 🔎✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
scolapasta
approved these changes
Jul 30, 2020
|
So, I tested all the rules and used cases as best I could. I think they all work except on upload when paths are involved for duplicates that have not yet been saved.
|
kcondon
moved this from QA 🔎✅
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
sekmiller
moved this from IQSS Team - In Progress 💻
to QA 🔎✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
sekmiller
moved this from QA 🔎✅
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
I was able to upload duplicate files and edit their paths and successfully save them |
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from IQSS Team - In Progress 💻
to Done 🚀
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This will allow users to upload multiple files with the same checksum value to a given dataset. On upload either via the interface or api the user will be warned that a duplicate file exists in the dataset (with the current path/label of the duplicate file.) At that point they can directly delete the newly uploaded file - if the upload is via the UI.
Which issue(s) this PR closes:
#4813 - allow files with the same MD5/checksum to exist in the same dataset
Closes #4813
Closes #6468
Special notes for your reviewer:
Really wanted to take a stick of dynamite to AddReplaceFileHelper, but ended up working with it as it exists. Also fixed an issue with the editFileMetadata api where if you weren't updating the file's label you'd get an duplicate file name error. This was causing a failure in the .testForceReplaceAndUpdate Test
Suggestions on how to test this:
various scenarios uploading a duplicate file including replace
document outlining upload use cases and expected messaging
Does this PR introduce a user interface change?:
Introduces a popup on upload of a duplicate file, which warns the user and allows them to immediately delete the newly uploaded file
Is there a release notes update needed for this change?:
We could note that duplicate files within a dataset are now allowed as a new feature
Additional documentation: