Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase default payara request timeout #6996

Merged
merged 6 commits into from Jun 30, 2020

Conversation

donsizemore
Copy link
Contributor

What this PR does / why we need it: increases the payara http request timeout from 15 mins to 30 mins, adds a default.config value for increasing this value during installation.

Which issue(s) this PR closes:

Closes #6927

Special notes for your reviewer: none

Suggestions on how to test this: re-run installer (-f --default_config= --noninteractive option combo is fine)

Does this PR introduce a user interface change? If mockups are available, please link/include them here: no

Is there a release notes update needed for this change?: no

Additional documentation: documented in config.rst

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple suggestions.

doc/sphinx-guides/source/installation/config.rst Outdated Show resolved Hide resolved
doc/sphinx-guides/source/installation/config.rst Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 17, 2020

Coverage Status

Coverage decreased (-0.003%) to 19.557% when pulling d954ae6 on OdumInstitute:6927_download_timeout into 7ff0124 on IQSS:develop.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Jun 18, 2020
@kcondon kcondon self-assigned this Jun 22, 2020
@kcondon kcondon merged commit 0a4ba60 into IQSS:develop Jun 30, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jun 30, 2020
@djbrooke djbrooke added this to the Dataverse 5 milestone Jun 30, 2020
@felker13
Copy link
Contributor

felker13 commented Jul 2, 2020

Since this PR is merged, I get the following error from the installer:
Traceback (most recent call last):
File "/tmp/dvinstall/install_ansible.py", line 512, in
if not runAsadminScript(config):
File "/tmp/dvinstall/installAppServer.py", line 15, in runAsadminScript
os.environ['GLASSFISH_REQUEST_TIMEOUT'] = config.get('glassfish','GLASSFISH_REQUEST_TIMEOUT')
File "/usr/lib/python2.7/ConfigParser.py", line 618, in get
raise NoOptionError(option, section)
ConfigParser.NoOptionError: No option 'glassfish_request_timeout' in section: 'glassfish'

@donsizemore
Copy link
Contributor Author

@felker13 To my knowledge install_ansible.py only exists in a fork of dataverse-ansible.

Have you compared your default.config template against https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/blob/master/templates/default.config.j2 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Download timeout after 15 minutes
6 participants