#6948 check file labels on new draft #7016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
added this to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Code Review 🦁
to QA 🔎✅
Jun 25, 2020
pdurbin
approved these changes
Jun 25, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a bug in which duplicate file names are allowed to saved in the case where the user is creating a new dataset version with the file upload.
Which issue(s) this PR closes:
Closes #6948
Special notes for your reviewer:
Pretty simple, I added a transient boolean to the file metadata to mark a metadata as existing in the previous version - the code had relied on the file metadata id for this, but it is null when a new edit version is created.
Suggestions on how to test this:
Upload a file that has the same name as a file in the current version of a dataset (but not the same content, because we aren't allowing that in dev, yet) and see that the file gets a -1 or -2 etc as applicable. This should happen in the file upload is done to a published version or an existing draft version.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No. It's a fairly minor bug fix
Additional documentation:
None