Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres 9.x EOL messaging, release notes updates for Postgres 10 #8310

Merged
merged 8 commits into from Jan 5, 2022

Conversation

djbrooke
Copy link
Contributor

@djbrooke djbrooke commented Dec 14, 2021

What this PR does / why we need it:

This is an attempt at supporting the plan laid out by @scolapasta in #8296 (comment)

Which issue(s) this PR closes:

Closes #8309

Special notes for your reviewer:

N/A

Suggestions on how to test this:

N/A

(edit from L.A.: As somebody who does perform upgrades, please see if the release note makes sense/answers questions you might have yourself)

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

N/A

Is there a release notes update needed for this change?:

N/A

Additional documentation:

N/A

@djbrooke
Copy link
Contributor Author

@scolapasta I'll tag you with this since you had laid out the plan. Let me know if you want to discuss, or feel free to edit directly. Thanks!

@djbrooke djbrooke changed the title Postgres update Postgres 9.x EOL messaging, release notes updates for Postgres 10 Dec 14, 2021
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good but we might want to update scripts/installer/README_python.txt as well since it references 9.6 as /usr/pgsql-9.6 and yum install postgresql96-devel. Please below for some context. I could just change it but @landreev might want to take a look since he wrote that doc.

make sure the version that you will be using with Dataverse is the
first on your PATH. For example,

   PATH=/usr/pgsql-9.6/bin:$PATH; export PATH

Certain libraries and source include files, both for PostgresQL and
Python, are also needed to compile the module. On
RedHat/CentOS/etc. you may need to install the -devel packages, *for
the specific versions* of PostgreSQL and Python you will be using. For
example:

	yum install postgresql96-devel
	yum install python37-devel
	etc. 

@pdurbin pdurbin self-assigned this Dec 15, 2021
@pdurbin pdurbin moved this from Review 🦁 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Dec 16, 2021
@pdurbin pdurbin moved this from IQSS Team - In Progress 💻 to Review 🦁 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Dec 16, 2021
@pdurbin pdurbin removed their assignment Dec 16, 2021
@pdurbin
Copy link
Member

pdurbin commented Dec 16, 2021

I upgraded postgres on my Mac from 9.6 to 13.5. It turns out that the directory is now "13" rather than "13.5" so I adjusted the docs to reflect this.

I also noticed that "md5" is no longer in pg_hba.conf. It's now "scram-sha-256". So I updated that too.

I think the only thing left is the readme in scripts/installer I mentioned above.

I may have heard that 9.6 is not technically EOL? I guess we could reword that a bit, if necessary.

Finally, I'll just mention that I don't upgrade postgres very often so I had to google how to stop the old instance. Otherwise the new instance would have used a non-standard port.

To stop postgres, this worked fine:

sudo -u postgres /Library/PostgreSQL/9.6/bin/pg_ctl stop -D /Library/PostgreSQL/9.6/data

I also ran this to (hopefully) have my old postgres not start on boot (haven't tested it yet):

sudo launchctl unload -w /Library/LaunchDaemons/com.edb.launchd.postgresql-9.6.plist

I got these from https://gist.github.com/sandrods/9c4873a18bbcd9051b56e8dde7ebd946

We may want to add these on the Tips page in the dev guide some day.

Copy link
Contributor

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and looks fine by me. I know @landreev was planning on adding a few words on our own upgrade experience, so I'll leave him assigned, but can otherwise me moved through.

@scolapasta scolapasta removed their assignment Dec 16, 2021
@djbrooke djbrooke added this to the 5.10 milestone Dec 16, 2021
@landreev landreev moved this from Review 🦁 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jan 3, 2022
@landreev
Copy link
Contributor

landreev commented Jan 4, 2022

Edited the release note, added upgrade instructions and command line examples. Going to move the PR back into the review column for somebody else to take a quick look. (Or can move into QA myself if everybody's ok with it)

@landreev landreev moved this from IQSS Team - In Progress 💻 to Review 🦁 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jan 4, 2022
@landreev landreev removed their assignment Jan 4, 2022

### PostgreSQL Version 10+ Required

If you are still using PostgreSQL 9.X, now is the time to upgrade. PostgreSQL is now EOL (no longer supported, as of January 2022), and the PostgreSQL driver in the next release of the Dataverse Software will no longer work with versions prior to 10.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PostgreSQL driver, or the FlyWay thing-a-ma-bob? (or both?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I get this wrong? I thought it was on account of Flyway, but the actual requirement was the driver... no?
Will fix!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Postgres driver is intentionally as backwards-compatible as possible; I understood that Flyway dropped 9.n when they added support for 14. A very minor point but... it might come up?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, corrected - thank you.

@pdurbin pdurbin self-assigned this Jan 5, 2022
@pdurbin
Copy link
Member

pdurbin commented Jan 5, 2022

I see this is back in review. I going to go ahead and tweak README_python.txt as I suggested in my initial review: #8310 (review)

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Heads up that in 2ca786e I updated the README_python.txt file for the installer, from 9.6 to 13.

@pdurbin pdurbin removed their assignment Jan 5, 2022
@kcondon kcondon self-assigned this Jan 5, 2022
@kcondon kcondon merged commit c4a1d87 into develop Jan 5, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jan 5, 2022
@kcondon kcondon deleted the 8309-postgres-updates branch January 5, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Postgres 9 EOL doc updates, Release note about Postgres versions
6 participants