Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Flyway to support PostgreSQL 14 #8296

Merged
merged 7 commits into from
May 16, 2022

Conversation

donsizemore
Copy link
Contributor

@donsizemore donsizemore commented Dec 8, 2021

What this PR does / why we need it:

Flyway 5.2.4 doesn't recognize the current version of PostgreSQL, 14.

Which issue(s) this PR closes:

Special notes for your reviewer: none

Suggestions on how to test this: run the integration test suite using PostgreSQL version 14

Does this PR introduce a user interface change? If mockups are available, please link/include them here: no

Is there a release notes update needed for this change?: no

Additional documentation: none

@kcondon kcondon self-assigned this Dec 10, 2021
@kcondon
Copy link
Contributor

kcondon commented Dec 10, 2021

@donsizemore This breaks any installation on postgres 9.6:
Caused by: org.flywaydb.core.internal.license.FlywayEditionUpgradeRequiredException: Flyway Teams Edition or PostgreSQL upgrade required: PostgreSQL 9.6 is no longer supported by Flyway Community Edition, but still supported by Flyway Teams Edition.
at org.flywaydb.core.internal.database.base.Database.ensureDatabaseNotOlderThanOtherwiseRecommendUpgradeToFlywayEdition(Database.java:127)

@kcondon kcondon assigned scolapasta and unassigned kcondon Dec 10, 2021
@scolapasta
Copy link
Contributor

We had a good discussion in slack about this, the conclusions seemed to be:
• this was a proactive switch for going to Postgres 14 (which we love), but no installation is in need of it just yet
• some installations may not want to move to 14 for various reasons, but we do want them to move past 9.6 (which is EOL in January)
• we should first get installation to move up, either via the release notes of the next version; or a dedicated intra release message stating that the next version will require a Postgres of higher than 9.6
• we can then make this change in the following release

@djbrooke I'll assign to you to decide how to handle (whether as release notes or separate message) and to move this to the appropriate column while it waits

@scolapasta scolapasta assigned djbrooke and unassigned scolapasta Dec 13, 2021
@djbrooke
Copy link
Contributor

@scolapasta - ok, I think I understand. So we could say in the 5.10 release notes that Postgres 10+ is required, and then add this PR in 5.11?

@donsizemore
Copy link
Contributor Author

Once merged, this will also close #8384.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this but the changes make sense the and the release notes look good.

@kcondon please not that Jenkins uses PG 13 but @donsizemore is offering to do a run with PG 14 if you'd like. The guides say, "The application has been tested with PostgreSQL versions up to 13 and version 10+ is required." We can certainly update that line to 14, if desired.

The big thing, of course, as we said in the 5.10 release notes, is that after this is merged, PG 9.6 will not be supported. I'm personally on PG 13 but I'll probably drop a note to the dev list after this is merged that they'll need to get off PG 9.6 if they haven't already.

@kcondon
Copy link
Contributor

kcondon commented May 13, 2022

@pdurbin Is there a good time in the sprint to do this? As in at the end after everybody has completed their work before they need to alter their dev env?

@kcondon kcondon self-assigned this May 13, 2022
@kcondon kcondon merged commit 74631bd into IQSS:develop May 16, 2022
@pdurbin
Copy link
Member

pdurbin commented May 16, 2022

Is there a good time in the sprint to do this? As in at the end after everybody has completed their work before they need to alter their dev env?

Not a ton of chatter about this in Slack: https://iqss.slack.com/archives/C010LA04BCG/p1652455817558209

In short, we think most developers are probably off postgres 9.6 by now but I did just email the dev list that now it the time to upgrade if they haven't already: https://groups.google.com/g/dataverse-dev/c/NOy16jExwyM/m/3xSiJmBwAwAJ

Again, in the 5.10 release notes we notified installations about the need to upgrade.

@kcondon
Copy link
Contributor

kcondon commented May 16, 2022

I spoke to members of local team and all were good.

@pdurbin pdurbin added this to the 5.11 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support PostgreSQL 14
5 participants