Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7715 signed urls for external tools #8850

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Jul 20, 2022

Some cleanup and using the util methods to read JsonObject/Arrays. Also added some fine logging for debug,

The two things I saw that I think are bugs are

  • using JsonString.toString() instead of JsonString.getString() - if I recall the former puts quotes around all of the strings, whereas getString gets the raw value (if I've got that mixed up, the logging statements should make it clear).
  • an if(redirect=true) that needed to use == - not sure if it was something that was getting triggered in your tests or not.

I also merged with the latest develop branch. If you don't want that, you can cherry pick 1b31e6c by itself.

pkiraly and others added 30 commits April 29, 2022 12:25
…IQSS/8595-CVV_solr_updates

IQSS/8595 - update existing schema and code to make all cvv files multival in solr
8650 ReadTheDocs based HTML guides preview
Prevent non-widgets from being embedded in iframes
add Style Guide to list of guides
s/for this storages/for this storage's/
…c-fixes

IQSS#8619 installation prerequisites documentation fixes


Conflicts:
doc/sphinx-guides/source/installation/config.rst
(new dvPageBlocks image at bottom)
Hopefully this wording is considered an improvement!

I also looked into the installation name and how it interacts
with :InstallationName and :SystemEmail.
…ation

IQSS#8617 Branding customization docs refactoring
kcondon and others added 28 commits June 13, 2022 15:49
…license_example

setting default license doesn't require edit-license.json
Documentation: Add SampleDB to the list of integrations
…pport

Iqss/8726 better HTTP range request support
…h_publicInstall

Iqss/8757 file restriction with public install
Bumps [jbcrypt](https://github.com/djmdjm/jBCrypt) from 0.3m to 0.4.
- [Release notes](https://github.com/djmdjm/jBCrypt/releases)
- [Commits](https://github.com/djmdjm/jBCrypt/commits)

---
updated-dependencies:
- dependency-name: org.mindrot:jbcrypt
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…bcrypt-0.4

Bump jbcrypt from 0.3m to 0.4
…orflow-file-types

File Recognition - Added computational workflow file types
…GDCC/8768-OAI-ORE_file_content_updates

HDC 3A: Update OAI-ORE contents to add collections, PID URL, brandname
…ed-files

BagIt Support - Improved ignored files for BagIt handler
…GDCC/8604-improve_archiver_error_handling

GDCC/8604 Improve archiver error handling
@rtreacy rtreacy merged commit 66355b0 into IQSS:7715-signed-urls-for-external-tools Jul 21, 2022
@pdurbin pdurbin added this to the 5.12 milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet