-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalization of ingest messages #9571
Internationalization of ingest messages #9571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks, @stevenferey!
I'm going to give this our smallest size estimate because it shouldn't be hard to test.
@@ -1809,6 +1809,8 @@ file.spss-savEncoding.current=Current Selection: | |||
file.spss-porExtraLabels=Variable Labels | |||
file.spss-porExtraLabels.title=Upload an additional text file with extra variable labels. | |||
file.spss-porExtraLabels.selectToAddBtn=Select File to Add | |||
file.ingest.saveFailed.message=Ingest succeeded, but failed to save the ingested tabular data in the database; no further information is available | |||
file.ingest.saveFailed.detail.message=Ingest succeeded, but failed to save the ingested tabular data in the database: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good, there's a space after the : even though it's hard to see.
@stevenferey is a first time contributor (❤️ thanks! ❤️ ) so I had to click the "run" button for the checks. |
Thanks for your feedback @pdurbin ! The error during the maven build is not to be related to the PR for me, is it? Thanks, |
@stevenferey no, this error is unrelated to your pull request:
Internally, we've been discussing how to fix this: https://iqss.slack.com/archives/C010LA04BCG/p1682360103211409 |
@stevenferey Please refresh this branch from develop since there is an outdated flyway db script name in this branch that is causing trouble deploying. Thanks! |
I took care of the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this by artificially adding some runtime exceptions, which I didn't commit, of course. Looks good to me. Thanks, @stevenferey!
@@ -128,9 +128,9 @@ public void onMessage(Message message) { | |||
IngestReport errorReport = new IngestReport(); | |||
errorReport.setFailure(); | |||
if (ex.getMessage() != null) { | |||
errorReport.setReport("Ingest succeeded, but failed to save the ingested tabular data in the database: " + ex.getMessage()); | |||
errorReport.setReport(BundleUtil.getStringFromBundle("file.ingest.saveFailed.detail.message") + ex.getMessage()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} else { | ||
errorReport.setReport("Ingest succeeded, but failed to save the ingested tabular data in the database; no further information is available"); | ||
errorReport.setReport(BundleUtil.getStringFromBundle("file.ingest.saveFailed.message")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What this PR does / why we need it:
Internationalization of ingest messages
Which issue(s) this PR closes: