Internationalization of ingest messages#9571
Conversation
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks, @stevenferey!
I'm going to give this our smallest size estimate because it shouldn't be hard to test.
| file.spss-porExtraLabels.title=Upload an additional text file with extra variable labels. | ||
| file.spss-porExtraLabels.selectToAddBtn=Select File to Add | ||
| file.ingest.saveFailed.message=Ingest succeeded, but failed to save the ingested tabular data in the database; no further information is available | ||
| file.ingest.saveFailed.detail.message=Ingest succeeded, but failed to save the ingested tabular data in the database: |
There was a problem hiding this comment.
Oh good, there's a space after the : even though it's hard to see.
|
@stevenferey is a first time contributor (❤️ thanks! ❤️ ) so I had to click the "run" button for the checks. |
pdurbin
added
Feature: Internationalization
Size: 3
|
Thanks for your feedback @pdurbin ! The error during the maven build is not to be related to the PR for me, is it? Thanks, |
|
@stevenferey no, this error is unrelated to your pull request:
Internally, we've been discussing how to fix this: https://iqss.slack.com/archives/C010LA04BCG/p1682360103211409 |
|
@stevenferey Please refresh this branch from develop since there is an outdated flyway db script name in this branch that is causing trouble deploying. Thanks! |
|
I took care of the merge. |
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I tested this by artificially adding some runtime exceptions, which I didn't commit, of course. Looks good to me. Thanks, @stevenferey!
| errorReport.setFailure(); | ||
| if (ex.getMessage() != null) { | ||
| errorReport.setReport("Ingest succeeded, but failed to save the ingested tabular data in the database: " + ex.getMessage()); | ||
| errorReport.setReport(BundleUtil.getStringFromBundle("file.ingest.saveFailed.detail.message") + ex.getMessage()); |
There was a problem hiding this comment.
To artificially test this I used the following code...
public boolean ingestAsTabular(Long datafile_id) {
+ if (true) {
+ throw (new RuntimeException("customMessage"));
+ }
DataFile dataFile = fileService.find(datafile_id);
... to create this screenshot, which looks good to me:
| errorReport.setReport(BundleUtil.getStringFromBundle("file.ingest.saveFailed.detail.message") + ex.getMessage()); | ||
| } else { | ||
| errorReport.setReport("Ingest succeeded, but failed to save the ingested tabular data in the database; no further information is available"); | ||
| errorReport.setReport(BundleUtil.getStringFromBundle("file.ingest.saveFailed.message")); |
There was a problem hiding this comment.
For this one I used...
public boolean ingestAsTabular(Long datafile_id) {
+ if (true) {
+ throw (new RuntimeException());
+ }
DataFile dataFile = fileService.find(datafile_id);
... to get this screenshot, which also looks fine to me:
5 participants
What this PR does / why we need it:
Internationalization of ingest messages
Which issue(s) this PR closes: