Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code coverage instrumentation for integration tests #4960

Closed
pameyer opened this issue Aug 14, 2018 · 7 comments
Closed

code coverage instrumentation for integration tests #4960

pameyer opened this issue Aug 14, 2018 · 7 comments
Assignees

Comments

@pameyer
Copy link
Contributor

pameyer commented Aug 14, 2018

unit tests are currently instrumented to measure code coverage, integration tests are not.

@oscardssmith
Copy link
Contributor

Any chance we can get coveralls to use this?

@pameyer
Copy link
Contributor Author

pameyer commented Aug 31, 2018

Not sure. I think that coveralls uses the result from travis, and I don't think that we've got travis setup to run integration tests.

@pameyer
Copy link
Contributor Author

pameyer commented Sep 4, 2018

@oscardssmith coveralls the GitHub integration (not without a way to run integration tests from something that integrates with GitHub), or coveralls the org.eluder.coveralls maven plugin (possibly)?

@pdurbin
Copy link
Member

pdurbin commented Sep 6, 2018

@pameyer I see you made pull request #5016 (thanks!) but this issue is still in the "inbox" according to https://waffle.io/IQSS/dataverse and I'm wondering if you're ready for code review.

@pameyer
Copy link
Contributor Author

pameyer commented Sep 6, 2018

@pdurbin It's ready for review, but also didn't seem worth interrupting the flow of what's already going on - and doesn't seem like it's likely to generate merge conflicts.

@pdurbin
Copy link
Member

pdurbin commented Sep 6, 2018

@pameyer ok, thanks, I went ahead and dragged it over to code review. I'm curious if the percentage is higher or lower than than the 16% we show currently for unit tests on our README:

screen shot 2018-09-06 at 6 33 02 pm

@pdurbin
Copy link
Member

pdurbin commented Sep 7, 2018

I'm moving this to QA because the directions are clear enough but I didn't try them myself. Note that there's a tip that this technique could be used in production to figure out how much code is actually exercised after a week or a month or whatever of usage. Pretty neat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants