Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for integration tests #6124

Closed
scolapasta opened this issue Aug 28, 2019 · 4 comments
Closed

Add code coverage for integration tests #6124

scolapasta opened this issue Aug 28, 2019 · 4 comments

Comments

@scolapasta
Copy link
Contributor

scolapasta commented Aug 28, 2019

This issue is related to #4960.

That issue was closed once documentation was added, but let's go further and actually add this to our process. In particular, with our new focus on integration tests over unit tests, this should help us fine which areas of the application are not being exercised by the current test so we can add new tests.

  • Percentage of coverage
  • Areas exercised and those not exercised

It would be great to include some coverage metric in the readme like we do for coveralls.

@pdurbin
Copy link
Member

pdurbin commented Oct 17, 2019

In pull request #6186 I improved the docs on how to get a code coverage report for API tests out of Dataverse. Sadly, this has not yet been automated. Just today @poikilotherm asked me if we plan to use Maven for this and we probably should but right now we're using a script and some documented commands. This issue isn't a sprint anymore though so I guess it'll have to wait unless someone from the community picks it up. Here are the new and improved docs from the pull request I mentioned: http://guides.dataverse.org/en/4.17/developers/testing.html#measuring-coverage-of-integration-tests

donsizemore added a commit to uncch-rdmc/dataverse that referenced this issue Jan 3, 2020
donsizemore added a commit to uncch-rdmc/dataverse that referenced this issue Jan 3, 2020
donsizemore added a commit to uncch-rdmc/dataverse that referenced this issue Jan 29, 2020
donsizemore added a commit to uncch-rdmc/dataverse that referenced this issue Jan 30, 2020
donsizemore added a commit to uncch-rdmc/dataverse that referenced this issue Jan 30, 2020
@donsizemore
Copy link
Contributor

Currently, Jenkins/Ansible are spitting out this:

Screen Shot 2020-02-25 at 07 56 26

and this: https://jenkins.dataverse.org/job/IQSS-dataverse-develop/364/jacoco/

next to review with @pdurbin and @scolapasta and decide which statia to publish.

@pdurbin
Copy link
Member

pdurbin commented Feb 25, 2020

It would be great to include some coverage metric in the readme like we do for coveralls.

I just split this off into its own small chunk:

@djbrooke
Copy link
Contributor

Much of this is now available at the bottom of the readme! Thanks @donsizemore!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants