Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trailing . to rsync command from rsal #5632

Merged
merged 1 commit into from Mar 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -14,7 +14,7 @@ public RsyncSite(String name, String fqdn, String fullRemotePathToDirectory) {
this.fqdn = fqdn;
this.fullRemotePathToDirectory = fullRemotePathToDirectory;
// TODO: Stop hard-coding "rsync" here one a field has been added to the StorageSite object (or related object).
this.rsyncDownloadcommand = "rsync -av rsync://" + this.fqdn + "" + File.separator + this.fullRemotePathToDirectory;
this.rsyncDownloadcommand = "rsync -av rsync://" + this.fqdn + "" + File.separator + this.fullRemotePathToDirectory + " .";
}

public String getName() {
Expand Down
Expand Up @@ -28,7 +28,7 @@ public void testGetRsalSites_3args() {
assertEquals("Harvard Medical School, USA", result.get(0).getName());
assertEquals("dv.sbgrid.org", result.get(0).getFqdn());
assertEquals("10.5072/FK2/identifierPartOfPersistentID", result.get(0).getFullRemotePathToDirectory());
assertEquals("rsync -av rsync://dv.sbgrid.org/10.5072/FK2/identifierPartOfPersistentID", result.get(0).getRsyncDownloadcommand());
assertEquals("rsync -av rsync://dv.sbgrid.org/10.5072/FK2/identifierPartOfPersistentID .", result.get(0).getRsyncDownloadcommand());
}

@Test
Expand Down