-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ability to reserve DOIs through DataCite #5093 #6901
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
49a5091
for DataCite, get PID (draft state) on create #5093
pdurbin cba83f5
add API to query PID state (e.g. draft vs. findable) #5093
pdurbin e72616f
add APIs to reserve PIDs and list unreserved PIDs #5093
pdurbin 431ee35
have "get DOI" accept normal form with doi: #5093
pdurbin 9cbd5d3
allow dataset to be created if DataCite is down #5093
pdurbin e8e4c98
add docs for undocumented APIs (list, reserve) #5093
pdurbin 28f3222
grey out publish button if DataCite and no PID create time #5093
pdurbin 8aacc92
add API to delete DOIs when possible #5093
pdurbin f58b24e
prevent publishing of unreserved PIDs #5093
pdurbin 85fd5be
get deleteIdentifier working for DataCite DOIs #5093
pdurbin 62509c8
only set the create time if createIdentifier succeeded #5093
pdurbin 1dfe944
finish removing RuntimeException (see 62509c89f) #5093
pdurbin 786a7a4
move English to bundle #5093
pdurbin 27da57a
document "delete PID" API endpoint #5093
pdurbin c700f61
Merge branch 'develop' into 5093-datacite #5093
pdurbin e1914ee
correct docs: "doi:" required for get PID API #5093
pdurbin dde481c
add release note #5093
pdurbin c1be93f
correct PID API docs for delete and reserve #5093
pdurbin 7821ac7
more descriptive error on bad API token than "ERROR" #5093
pdurbin 6bc7d93
cross ref PID-related docs #5093
pdurbin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
If you are using DataCite as your DOI provider you must add a new JVM option called "doi.baseurlstringnext" with a value of "https://api.datacite.org" for production environments and "https://api.test.datacite.org" for test environments. More information about this JVM option can be found in the Installation Guide. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is specific to DataCite, it might be better to name it for that - doi.dataciteapibaseurl or something. (FWIW - I could swear that at some point I discussed adding a second option versus swapping mds for api in baseurlstring with someone and decided against having a second option, but I can't find code nor conversation...)