Database indexing: fix mismatching balances/sent/received, negative balances etc #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheHolyRoger
force-pushed
the
devfix-balance_mismatch
branch
5 times, most recently
from
33967bd
to
a4677a4
Compare
|
Includes new db lock setting during indexing and also displays initial_index_alert warning whilst locked. I found that allowing API requests to save transactions out of order during indexing causes balance issues, whilst this new setting limits functionality during indexing, it does help ensure balances are accurate. |
|
@uaktags @cryptozeny @iquidus would appreciate your thoughts |
TheHolyRoger
force-pushed
the
devfix-balance_mismatch
branch
from
a4677a4
to
f8289fe
Compare
|
wow i will look as soon as possible |
TheHolyRoger
force-pushed
the
devfix-balance_mismatch
branch
5 times, most recently
from
f434e83
to
73c6be6
Compare
TheHolyRoger
commented
Dec 19, 2019
| received = received + amount; | ||
| } | ||
| if (unique == true) { | ||
| if ((unique == true) || (type != tx_array[index].type)) { |
There was a problem hiding this comment.
There was some duplicated code here, have stripped it down as it wasn't catching tx's sent to self properly
TheHolyRoger
force-pushed
the
devfix-balance_mismatch
branch
from
beacd19
to
318f8eb
Compare
TheHolyRoger
force-pushed
the
devfix-balance_mismatch
branch
from
318f8eb
to
84cfbea
Compare
10 tasks
|
Included in PR #319 |
|
i cherry picked this commit, and rebuilt explorer, but still same. i will try |
|
Continued in #319 |
|
i did
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently testing these changes out with a reindex to see if the balance discrepancies are resolved.
Would fix:
#293
uaktags#42
sugarchain-project#13
Relates to changes since:
#6
So far everything seems to be working well now - if you do have balance issues then you'll want to reindex after merging this PR. I advise turning on the lock_during_index setting to ensure API calls don't mess up balances out of order.
A reindex is NOT required with this PR - only advised if you have balance issues.