Major: Full address history with AJAX loading + Database indexing updates - fix mismatching balances/sent/received, negative balances etc #319
Conversation
Commented out, prior to my PR, so its unrelated! Co-Authored-By: M-Shahbaz <mr.shahbaz.aslam@gmail.com>
If the query.length is type string, it will parse to integer and will work for both: 1-Undefined 2-String type
|
what a PR? looks awesome! i will check if i can. |
|
I'm liking what I see, been tracking all the email notifications. I'll review and merge soon this weekend/before Xmas |
|
Address history TXs are displaying out of order at the moment but I'll fix that later |
|
welcome new maintainer roger! 😘 btw, what this means? side effect?
|
TheHolyRoger
force-pushed
the
major-address-history
branch
from
e53a164
to
e26ff52
Compare
I think I've already fixed it :) doing another reindex now to make sure |
|
This all seems to be working now here https://explorer.theholyroger.com/address/Ri8CZahkgaXQTmRdQ21P6ZezCq1UKZ5RT4 I couldn't get these addresses to "0" before. Monstrous address loaded using ajax: |
|
Looking good, we will need more reviewers and QAs to make it happen! |
|
I'm considering extending this PR to add previous balance history on the address history page like: https://chainz.cryptoid.info/roger/address.dws?57138.htm Thoughts? |
do you mean, add balance history on right side?
|
Yes exactly |
|
great, i agreed! |
|
@cryptozeny now working here https://explorer.theholyroger.com/address/RogerV1FqDxkqj1PPxHbjmU4r3JAk5oB3U I've just started a new reindex again so it's not complete, but you can at least see it working :) |
TheHolyRoger
force-pushed
the
major-address-history
branch
from
1491f3a
to
9c9aca0
Compare
|
@TheHolyRoger can you edit your first post with a checkbox list and list out the todos with this. Definitely seems like a great bundle of fixes, but would hate to see the same rabbit hole followed as me where a PR just becomes too large to review! I may break down my repo back into smaller fixes like this as well for the PUG updates, the cluster work, and masternodes, Right now there's just too many commits without me taking a breather to use my branch as is. |
|
@uaktags don't worry about the pug stuff :) - I've already got another branch ready to make a PR for pug But as that itself is a big change I wanted to iron out this PR and get it merged first - then PUG is a very easy merge and we won't be far off all the stuff from your fork then :D With regards to this PR - as far as I can tell everything is working now, just fixed a couple of bugs/warnings now |
|
@uaktags pug changes based off this PR are working here TheHolyRogerCoin@4c0d12a so easy for me to break it into a new PR after this one! |
|
Awesome, I'll check it out. Yea once we can get onto a reviewed and working
base, it'll be great to bring over all the exchanges I updated to pug lol.
…On Mon, Dec 23, 2019 at 5:54 PM TheHolyRoger ***@***.***> wrote:
@uaktags <https://github.com/uaktags> pug changes based off this PR are
working here
https://github.com/TheHolyRogerCoin/RogerXplorer/tree/major-jade-to-pug
so easy for me to break it into a new PR after this one!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#319?email_source=notifications&email_token=AAG2F5G2FVOGFHIMTAR2CIDQ2E6TJA5CNFSM4J56UHSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHSCM2Y#issuecomment-568600171>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG2F5DO7DHFZD23MHENNBTQ2E6TJANCNFSM4J56UHSA>
.
|
TheHolyRoger
force-pushed
the
major-address-history
branch
2 times, most recently
from
60c9b74
to
d41d853
Compare
TheHolyRoger
force-pushed
the
major-address-history
branch
from
d41d853
to
a57e734
Compare
…khash Another indexing speed-up
There was a problem hiding this comment.
Tested against XPChain and Vulcano without issues.
Tested in the following environments:
Win10 x64
nvm to use node v6.17.1 as well as 8.17.0
Also used mazanode-iquidus's docker container as base for this as well.
Initital sync/reindexes were ran 10x with use_rpc:true as well as use_rpc:false, and I self-limited the sync to 1000 blocks. On average saved about 3-5seconds with the new use_rpc:false parameter. Obviously you'd want to go further with the sync, but I've tested this extensively in my own PR previously.
1.6.2 doesn't add any new functionality (just more stability and speed enhancements) so I agree staying with the 1.6.x is perfect until the next milestone as previously discussed for 1.7.x
|
awesome job guys! 🥳 happy xmas! 🎄 |
…story Major: Full address history with AJAX loading + Database indexing updates - fix mismatching balances/sent/received, negative balances etc
Will be closing these PRs as I've merged them into this one.
#316
#270
@uaktags @M-Shahbaz thank you very much for your work on this.
This PR WILL require a REINDEX unfortunately, but indexing is now much much faster.
See the UPGRADE notes for steps required merging this PR: https://github.com/TheHolyRogerCoin/RogerXplorer/blob/major-address-history/UPGRADE#L3
Done:
Fixes issues:
More discussion here:
Working examples: