Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major: Full address history with AJAX loading + Database indexing updates - fix mismatching balances/sent/received, negative balances etc #319

Merged
merged 28 commits into from Dec 24, 2019

Conversation

@TheHolyRoger
Copy link
Collaborator

TheHolyRoger commented Dec 20, 2019

Will be closing these PRs as I've merged them into this one.

#316
#270

@uaktags @M-Shahbaz thank you very much for your work on this.

This PR WILL require a REINDEX unfortunately, but indexing is now much much faster.

See the UPGRADE notes for steps required merging this PR: https://github.com/TheHolyRogerCoin/RogerXplorer/blob/major-address-history/UPGRADE#L3

Done:

  • MongoDB collections updated (Added AddressTX)
  • Stores all address transaction history (no truncation)
  • Show all Address history using DataTables ajax loading & use txlimit settings for paging
  • Added new file lock during database indexing: tmp/db_index.pid
  • New setting to lock during indexing: lock_during_index
  • Fix mismatching balances/sent/received, negative balances etc
  • Address Page: Moved QR Code to Address Summary table
  • DataTables - Latest TXs - configurable "Entries" pickers for rows (same as Address History)
  • Show digits post-decimals in new CSS class so that they appear smaller
  • Add more settings to pick default dataTables entries

Fixes issues:

More discussion here:

Working examples:

M-Shahbaz and others added 4 commits Mar 4, 2019
Commented out, prior to my PR, so its unrelated!

Co-Authored-By: M-Shahbaz <mr.shahbaz.aslam@gmail.com>
If the query.length is type string, it will parse to integer and will work for both:
1-Undefined
2-String type
@TheHolyRoger TheHolyRoger requested review from iquidus and uaktags Dec 20, 2019
@cryptozeny

This comment has been minimized.

Copy link

cryptozeny commented Dec 20, 2019

what a PR? looks awesome! i will check if i can.

@uaktags

This comment has been minimized.

Copy link
Collaborator

uaktags commented Dec 20, 2019

I'm liking what I see, been tracking all the email notifications. I'll review and merge soon this weekend/before Xmas

@TheHolyRoger

This comment has been minimized.

Copy link
Collaborator Author

TheHolyRoger commented Dec 20, 2019

Address history TXs are displaying out of order at the moment but I'll fix that later

@cryptozeny

This comment has been minimized.

Copy link

cryptozeny commented Dec 20, 2019

welcome new maintainer roger! 😘

btw, what this means? side effect?

Address history TXs are displaying out of order at the moment

@TheHolyRoger TheHolyRoger force-pushed the TheHolyRogerCoin:major-address-history branch from e53a164 to e26ff52 Dec 20, 2019
@TheHolyRoger

This comment has been minimized.

Copy link
Collaborator Author

TheHolyRoger commented Dec 20, 2019

welcome new maintainer roger! 😘

btw, what this means? side effect?

Address history TXs are displaying out of order at the moment

I think I've already fixed it :) doing another reindex now to make sure

@TheHolyRoger

This comment has been minimized.

Copy link
Collaborator Author

TheHolyRoger commented Dec 21, 2019

@minkcrypto

This comment has been minimized.

Copy link
Contributor

minkcrypto commented Dec 21, 2019

Looking good, we will need more reviewers and QAs to make it happen!

@TheHolyRoger

This comment has been minimized.

Copy link
Collaborator Author

TheHolyRoger commented Dec 21, 2019

I'm considering extending this PR to add previous balance history on the address history page like: https://chainz.cryptoid.info/roger/address.dws?57138.htm

Thoughts?

@cryptozeny

This comment has been minimized.

Copy link

cryptozeny commented Dec 21, 2019

I'm considering extending this PR to add previous balance history on the address history page like: https://chainz.cryptoid.info/roger/address.dws?57138.htm

do you mean, add balance history on right side?

image

@TheHolyRoger

This comment has been minimized.

Copy link
Collaborator Author

TheHolyRoger commented Dec 21, 2019

I'm considering extending this PR to add previous balance history on the address history page like: https://chainz.cryptoid.info/roger/address.dws?57138.htm

do you mean, add balance history on right side?

image

Yes exactly

@cryptozeny

This comment has been minimized.

Copy link

cryptozeny commented Dec 22, 2019

great, i agreed!

@TheHolyRoger

This comment has been minimized.

Copy link
Collaborator Author

TheHolyRoger commented Dec 22, 2019

@cryptozeny now working here https://explorer.theholyroger.com/address/RogerV1FqDxkqj1PPxHbjmU4r3JAk5oB3U

I've just started a new reindex again so it's not complete, but you can at least see it working :)

@TheHolyRoger TheHolyRoger force-pushed the TheHolyRogerCoin:major-address-history branch from 1491f3a to 9c9aca0 Dec 23, 2019
@uaktags

This comment has been minimized.

Copy link
Collaborator

uaktags commented Dec 23, 2019

@TheHolyRoger can you edit your first post with a checkbox list and list out the todos with this. Definitely seems like a great bundle of fixes, but would hate to see the same rabbit hole followed as me where a PR just becomes too large to review!

I may break down my repo back into smaller fixes like this as well for the PUG updates, the cluster work, and masternodes, Right now there's just too many commits without me taking a breather to use my branch as is.

@TheHolyRoger

This comment has been minimized.

Copy link
Collaborator Author

TheHolyRoger commented Dec 23, 2019

@uaktags don't worry about the pug stuff :) - I've already got another branch ready to make a PR for pug

But as that itself is a big change I wanted to iron out this PR and get it merged first - then PUG is a very easy merge and we won't be far off all the stuff from your fork then :D

With regards to this PR - as far as I can tell everything is working now, just fixed a couple of bugs/warnings now

@uaktags uaktags removed the request for review from iquidus Dec 23, 2019
@TheHolyRoger

This comment has been minimized.

Copy link
Collaborator Author

TheHolyRoger commented Dec 23, 2019

@uaktags pug changes based off this PR are working here TheHolyRogerCoin@4c0d12a

so easy for me to break it into a new PR after this one!

@uaktags

This comment has been minimized.

Copy link
Collaborator

uaktags commented Dec 23, 2019

@TheHolyRoger TheHolyRoger force-pushed the TheHolyRogerCoin:major-address-history branch 2 times, most recently from 60c9b74 to d41d853 Dec 24, 2019
@TheHolyRoger TheHolyRoger force-pushed the TheHolyRogerCoin:major-address-history branch from d41d853 to a57e734 Dec 24, 2019
…khash

Another indexing speed-up
Copy link
Collaborator

uaktags left a comment

Tested against XPChain and Vulcano without issues.
Tested in the following environments:

Win10 x64
nvm to use node v6.17.1 as well as 8.17.0

Also used mazanode-iquidus's docker container as base for this as well.

Initital sync/reindexes were ran 10x with use_rpc:true as well as use_rpc:false, and I self-limited the sync to 1000 blocks. On average saved about 3-5seconds with the new use_rpc:false parameter. Obviously you'd want to go further with the sync, but I've tested this extensively in my own PR previously.

1.6.2 doesn't add any new functionality (just more stability and speed enhancements) so I agree staying with the 1.6.x is perfect until the next milestone as previously discussed for 1.7.x

@TheHolyRoger TheHolyRoger merged commit 8d44d4a into iquidus:master Dec 24, 2019
@cryptozeny

This comment has been minimized.

Copy link

cryptozeny commented Dec 24, 2019

awesome job guys! 🥳 happy xmas! 🎄

@TheHolyRoger TheHolyRoger deleted the TheHolyRogerCoin:major-address-history branch Dec 25, 2019
willli666 added a commit to atlantiscoin/explorer that referenced this pull request Jan 1, 2020
…story

Major: Full address history with AJAX loading + Database indexing updates - fix mismatching balances/sent/received, negative balances etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.