Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix subproc wait test #51

Merged
merged 1 commit into from
Mar 30, 2018
Merged

TST: Fix subproc wait test #51

merged 1 commit into from
Mar 30, 2018

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 30, 2018

Like #50 but for Jenkins CI.

@pllim pllim merged commit 9e479d1 into iraf-community:master Mar 30, 2018
@pllim pllim deleted the tst-subproc-wait branch March 30, 2018 19:56
@cdsontag
Copy link
Contributor

This is what frightens me a bit. Before you fixed it, the test did nothing, and it was known to do nothing (from the comment), and yet it was left that way.

@pllim
Copy link
Contributor Author

pllim commented Mar 30, 2018

There are currently only a few of such tests and they are all being tracked at #48. If you know how to fix up the rest, please do! 😉

(For all I know, it might not have been working properly too in pandokia, but it is just more visible now. This is unconfirmed though.)

@cdsontag
Copy link
Contributor

Love to help out with more (I would!) but I've already spent way too much time on this. Hey - have you guys abandoned pypi? If not, we need to update what is out on pypi.

For all I know, it might not have been working properly too in pandokia, but it is just more visible now. This is unconfirmed though.

Nahh - it's been working there for years. I posted in the other PR about just now finding when the test code recently got changed from using == to using is.

@pllim
Copy link
Contributor Author

pllim commented Mar 30, 2018

If not, we need to update what is out on pypi.

What do you mean? PyPI seems to be pointing to the same GitHub release (2.1.14).

@cdsontag
Copy link
Contributor

I mean basically we should get the latest code into pypi (which I guess means make a release). It's been quite a while.

@pllim
Copy link
Contributor Author

pllim commented Mar 30, 2018

I'll open an issue with your request, but maybe we should wait for some patches from @jehturner first. Also, I don't have access to this package's PyPI, so it would have to be Joe or Matt when the time comes.

@pllim pllim mentioned this pull request Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants