Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Add a PY3 job but allow it to fail #54

Merged
merged 3 commits into from
Apr 4, 2018
Merged

TST: Add a PY3 job but allow it to fail #54

merged 3 commits into from
Apr 4, 2018

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 4, 2018 •
edited

Let's see how this goes... 🔥

Incidentally, fix #38

@pllim pllim mentioned this pull request Apr 4, 2018
Merged
@pllim
Copy link
Contributor Author

pllim commented Apr 4, 2018

@jehturner , when this is merged (which will be shortly) and you rebase your PR against master, your PR would have a PY3 build for your reference. However, please note that unlike Travis CI, the job that is allowed to fail in Jenkins will show as green; Ignore that. Expand it to see the actual log of errors.

@pllim pllim merged commit feab2d4 into iraf-community:master Apr 4, 2018
@pllim pllim deleted the py3-tests branch April 4, 2018 17:23
@pllim pllim mentioned this pull request Apr 4, 2018
Closed
cdsontag
cdsontag reviewed Apr 4, 2018
View reviewed changes
setup.cfg
@@ -25,12 +25,12 @@ data_files =
pyraf/clcache = data/clcache/*
scripts = scripts/pyraf

[extension=pyraf.sscanfmodule]
[extension=pyraf.sscanf]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pllim doesn't this break the import of sscanf in pyraf in Py2 ? (same question for xutil)

It wasn't clear to me where to find the link to the passing Py2-based tests in the "Conversation" tab of this PR.

Copy link
Contributor Author

@pllim pllim Apr 5, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chris, I'll write up on how to check the Jenkins results as a new issue (see #58), so others might benefit from the information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this break the import of sscanf in pyraf in Py2 ?

@cdsontag , as far as we could test (both on Jenkins and locally for three different people on different machines, namely @rendinam , @jhunkeler , and myself), this did not break from pyraf import sscanf in Python 2 nor 3. Please let us know if you find otherwise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. Same conclusion for xutil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdsontag cdsontag cdsontag left review comments

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build C-extension in Python 3.6
2 participants
@pllim @cdsontag