-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Add a PY3 job but allow it to fail #54
Conversation
@jehturner , when this is merged (which will be shortly) and you rebase your PR against |
@@ -25,12 +25,12 @@ data_files = | |||
pyraf/clcache = data/clcache/* | |||
scripts = scripts/pyraf | |||
|
|||
[extension=pyraf.sscanfmodule] | |||
[extension=pyraf.sscanf] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pllim doesn't this break the import of sscanf in pyraf in Py2 ? (same question for xutil)
It wasn't clear to me where to find the link to the passing Py2-based tests in the "Conversation" tab of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chris, I'll write up on how to check the Jenkins results as a new issue (see #58), so others might benefit from the information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't this break the import of sscanf in pyraf in Py2 ?
@cdsontag , as far as we could test (both on Jenkins and locally for three different people on different machines, namely @rendinam , @jhunkeler , and myself), this did not break from pyraf import sscanf
in Python 2 nor 3. Please let us know if you find otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s. Same conclusion for xutil
.
Let's see how this goes... 🔥
Incidentally, fix #38