Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix merge failed when launch merger faster than laser #33

Closed

Conversation

Tacha-S
Copy link

@Tacha-S Tacha-S commented Sep 3, 2020

Related Issues or PRs
#5 #16 #17 (maybe #32)

#16 and #17 have a problem.
These PRs never merge when laserscan_topics contained one or more unknown topics.
To prevent it, when triggered scanCallback by one of subscribers, clouds_modified that the topic has no publisher set to true.

I hope this package works better regardless of launch order and makes this package more convenience.

@JackFrost67
Copy link
Contributor

i've tested, but it doesn't work, thank you for the pull, I've made some changes and now there is no problem with the launch of the merger.

@JackFrost67 JackFrost67 closed this Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants