Update TelegramRequest.php #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in construct when properties could be null, type of these setter methods value should be also include type of null. in other case these errors will throw : Argument irazasyed#1 ($accessToken) must be of type string, null given Argument irazasyed#1 ($endpoint) must be of type string, null given Argument irazasyed#1 ($method) must be of type string, null given
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1054 +/- ##
==========================================
Coverage 43.76% 43.76%
Complexity 609 609
==========================================
Files 129 129
Lines 1805 1805
==========================================
Hits 790 790
Misses 1015 1015
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Will this work in the required minimum PHP version? |
|
in this file, there was type definition on each method inputs variable, and the type of property accessToken is already '?string'. |
|
Yes. I merged it after checking. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in construct when properties could be null, type of these setter methods value should be also include type of null. in other case these errors will throw :
Argument #1 ($accessToken) must be of type string, null given
Argument #1 ($endpoint) must be of type string, null given
Argument #1 ($method) must be of type string, null given