Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP 7.2 support and update phpunit #966

Merged
merged 5 commits into from
Jul 7, 2022

Conversation

alies-dev
Copy link
Contributor

Goals:

  • fix tests on CI (phpunit 8.X can't be installed on php 7.2)
  • help PHP ecosystem by forcing developers using supported PHP version (all versions older 7.4 are EOL)

Error:
Error: kylekatarnls/update-helper contains a Composer plugin which is blocked by your allow-plugins config. You may add it to the list if you consider it safe.
You can run "composer config --no-plugins allow-plugins.kylekatarnls/update-helper [true|false]" to enable it (true) or disable it explicitly and suppress this exception (false)
See https://getcomposer.org/allow-plugins
In PluginManager.php line 762:
  kylekatarnls/update-helper contains a Composer plugin which is blocked by y
  our allow-plugins config. You may add it to the list if you consider it saf
  e.
  You can run "composer config --no-plugins allow-plugins.kylekatarnls/update
  -helper [true|false]" to enable it (true) or disable it explicitly and supp
  ress this exception (false)
  See https://getcomposer.org/allow-plugins
PHPUnit 9.0.0 by Sebastian Bergmann and contributors.
Runtime:       PHP 8.0.20
Configuration: /home/runner/work/telegram-bot-sdk/telegram-bot-sdk/phpunit.xml.dist
  Warning - The configuration file did not pass validation!
  The following problems have been detected:
  Line 14:
  - Element 'coverage': This element is not expected.
  Test results may not be as expected.
PHP Fatal error:  Type declaration 'mixed' must be unqualified in /home/runner/work/telegram-bot-sdk/telegram-bot-sdk/vendor/phpspec/prophecy/src/Prophecy/Doubler/Generator/ClassCreator.php(49) : eval()'d code on line 323
......................................................
Error: Process completed with exit code 255.
"sort-packages": true
"sort-packages": true,
"allow-plugins": {
"kylekatarnls/update-helper": true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependencies of dependencies installs it on low Laravel or PHP versions

@alies-dev
Copy link
Contributor Author

@irazasyed
Green CI, again! I will appreciate your review for this and #965 PRs. And, I think, after merging them, it's a good time to release v3.7.0. WDYT?

@irazasyed irazasyed merged commit 0181e8e into irazasyed:develop Jul 7, 2022
@irazasyed
Copy link
Owner

This is good. Thanks!! Much appreciated.

Sure. I'll tag shortly.

@irazasyed
Copy link
Owner

I just tagged but looks like there are tests still failing. Please look into it ASAP @lptn

@alies-dev alies-dev deleted the drop-php-7.2-support branch July 8, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants