Fix type issue parsing "entities" #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before review
It's better to firstly merge #966 (where I've fixed tests on CI). Tests failing for a long time, it's not caused by this PR
Description
Because we fixed one-to-many relationships, now we have collections on objects instead of collections of arrays.
Currently I've located a related bug caused by a change in this line: koot-labs@55c2b7e#diff-57d0f563404fb108cfd0cbe4edfec9b74c6ad896942dcff31be394e8dd7461e4R74
the fix is ready and tested on a live bot