Fix SASL 3.1, aborted is 906 not 904 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add this to the errata section |
|
Last time I remember looking into this, client-initiated abort wasn't actually implemented as such – services merely treated I'm fine either way; 906 would certainly make more sense. |
aaronmdjones
added a commit
to atheme/atheme
that referenced
this pull request
Apr 6, 2018
We already fail to base64_decode() it and then abort the session anyway, but this just saves time and avoids trying to decode it in the first place, which will always fail and produce an error message in the debug log. cf. ircv3/ircv3-specifications#298 (comment) Reported-By: James Wheare
aaronmdjones
added a commit
to charybdis-ircd/charybdis
that referenced
this pull request
Apr 6, 2018
Otherwise we'd send the * on to services as actual data, which is likely to fail to decode it (it's not valid Base-64) and reply with an SASL ... D F which will result in us sending a 904 numeric instead of a 906. cf. ircv3/ircv3-specifications#298 (comment) Reported-By: James Wheare
aaronmdjones
added a commit
to charybdis-ircd/charybdis
that referenced
this pull request
Apr 6, 2018
Otherwise we'd send the * on to services as actual data, which is likely to fail to decode it (it's not valid Base-64) and reply with an SASL ... D F which will result in us sending a 904 numeric instead of a 906. cf. ircv3/ircv3-specifications#298 (comment) Reported-By: James Wheare
aaronmdjones
added a commit
to charybdis-ircd/charybdis
that referenced
this pull request
Apr 6, 2018
Otherwise we'd send the * on to services as actual data, which is likely to fail to decode it (it's not valid Base-64) and reply with an SASL ... D F which will result in us sending a 904 numeric instead of a 906. cf. ircv3/ircv3-specifications#298 (comment) Reported-By: James Wheare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification mentions:
However later we say this returns 906 numeric: