Skip to content

Commit

Permalink
Bump actions/checkout to v4.1.7. (#17703)
Browse files Browse the repository at this point in the history
This should (hopefully) fix warnings about "Node.js 16 actions are
deprecated. Please update the following actions to use Node.js 20" in CI
logs. For example:
https://github.com/iree-org/iree/actions/runs/9575919714

![image](https://github.com/iree-org/iree/assets/4010439/33699fe2-5a62-4874-8318-2e2d50f2b8e2)

We have been using commit hashes instead of tags, since they are more
stable and that was a policy recommendation for Google-managed GitHub
repos:
https://opensource.google/documentation/reference/github/services#actions
> When using a third-party action (one not hosted in a Google-managed
org), a fixed version of the action MUST be used by [specifying a
specific
commit](https://help.github.com/en/github/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepsuses),
rather than a branch like "master", or a tagged release, which can be
overwritten by any maintainer of the action. Docker images should always
be run at a fixed version rather than "latest".

Using release tags is easier and more common, so switching back to that
style.
  • Loading branch information
ScottTodd committed Jun 19, 2024
1 parent d792d24 commit 1997902
Show file tree
Hide file tree
Showing 22 changed files with 84 additions and 82 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
E2E_TEST_ARTIFACTS_GCS_ARTIFACT_DIR: ${{ needs.build_e2e_test_artifacts.outputs.e2e-test-artifacts-gcs-artifact-dir }}
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: "Downloading install dir archive"
Expand Down Expand Up @@ -169,7 +169,7 @@ jobs:
EXECUTION_BENCHMARK_RESULTS_GCS_ARTIFACT_DIR: ${{ needs.execution_benchmarks.outputs.benchmark-results-gcs-artifact-dir }}
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
with:
# We need the full history (and main branch) to generate the report.
fetch-depth: 0
Expand Down Expand Up @@ -262,7 +262,7 @@ jobs:
- process_benchmark_results
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: Getting failed jobs
id: failed_jobs
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/benchmark_compilation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
compile-stats-results-gcs-artifact: ${{ steps.upload.outputs.compile-stats-results-gcs-artifact }}
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Downloading assets"
id: "download-assets"
env:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/benchmark_execution.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ env:
jobs:
generate_matrix:
runs-on:
- self-hosted # must come first
- self-hosted # must come first
- runner-group=${{ inputs.runner-group }}
- environment=${{ inputs.runner-env }}
- cpu
Expand All @@ -65,7 +65,7 @@ jobs:
benchmark-matrix: ${{ steps.generate.outputs.benchmark-matrix }}
steps:
- name: "Checking out repository"
uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3 # v3.5.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: "Generating benchmark matrix"
Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
matrix:
benchmark: ${{ fromJSON(needs.generate_matrix.outputs.benchmark-matrix) }}
runs-on:
- self-hosted # must come first
- self-hosted # must come first
- runner-group=${{ inputs.runner-group }}
- environment=${{ inputs.runner-env }}
- machine-type=${{ matrix.benchmark.device_name }}
Expand All @@ -136,7 +136,7 @@ jobs:
benchmark-results-gcs-artifact-dir: ${{ env.GCS_DIR }}/${{ env.BENCHMARK_RESULTS_DIR }}
steps:
- name: "Checking out repository"
uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3 # v3.5.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: "Downloading benchmark tools"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/benchmark_trigger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ env:
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
# Target workflow that runs the benchmarks.
WORKFLOW_NAME: Benchmark
BENCHMARK_LABEL_PREFIX: 'benchmarks:'
BENCHMARK_LABEL_PREFIX: "benchmarks:"

jobs:
# Precondition check is a separate step because we can't put the concurrency
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
- name: "Checking out repository"
# This checkouts from the base branch instead of the pull request. See
# https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3 # v3.5.0
uses: actions/checkout@v4.1.7

- name: "Finding the previous workflow run"
id: find-workflow
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
install-dir-gcs-url: ${{ steps.install-upload.outputs.install-dir-gcs-url }}
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
with:
submodules: true
- name: "Building IREE"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build_and_test_android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
target-build-dir-gcs-artifact: ${{ steps.upload.outputs.target-build-dir-gcs-artifact }}
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: "Downloading install dir archive"
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
TARGET_BUILD_DIR_GCS_ARTIFACT: ${{ needs.cross_compile.outputs.target-build-dir-gcs-artifact }}
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Downloading target build archive"
run: |
gcloud storage cp "${TARGET_BUILD_DIR_GCS_ARTIFACT}" "${TARGET_BUILD_DIR_ARCHIVE}"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_benchmark_tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
INSTALL_DIR_GCS_ARTIFACT: ${{ inputs.install-dir-gcs-artifact }}
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: "Downloading install dir archive"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_e2e_test_artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
e2e-test-artifacts-build-log-gcs-artifact: ${{ steps.upload.outputs.e2e-test-artifacts-build-log-gcs-artifact }}
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: "Downloading install dir archive"
Expand Down
13 changes: 8 additions & 5 deletions .github/workflows/build_package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,23 +43,26 @@ jobs:
build-family: linux-x86_64
build-package: main-dist-linux
experimental: false
- runs-on: [self-hosted, arm64, os-family=Linux, runner-group=postsubmit]
- runs-on:
[self-hosted, arm64, os-family=Linux, runner-group=postsubmit]
build-family: linux-aarch64
build-package: main-dist-linux
experimental: true
- runs-on: [managed-releaser, os-family=Linux, runner-group=releaser]
build-family: linux-x86_64
build-package: py-compiler-pkg
experimental: false
- runs-on: [self-hosted, arm64, os-family=Linux, runner-group=postsubmit]
- runs-on:
[self-hosted, arm64, os-family=Linux, runner-group=postsubmit]
build-family: linux-aarch64
build-package: py-compiler-pkg
experimental: true
- runs-on: [managed-releaser, os-family=Linux, runner-group=releaser]
build-family: linux-x86_64
build-package: py-runtime-pkg
experimental: false
- runs-on: [self-hosted, arm64, os-family=Linux, runner-group=postsubmit]
- runs-on:
[self-hosted, arm64, os-family=Linux, runner-group=postsubmit]
build-family: linux-aarch64
build-package: py-runtime-pkg
experimental: true
Expand Down Expand Up @@ -103,9 +106,9 @@ jobs:
MANYLINUX_AARCH64_IMAGE: quay.io/pypa/manylinux_2_28_aarch64

steps:
- uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3 # v3.5.0
- uses: actions/checkout@v4.1.7
with:
path: "c" # Windows can hit path length limits, so use a short path.
path: "c" # Windows can hit path length limits, so use a short path.
submodules: true
ref: ${{ github.event.inputs.commit }}

Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/bump_torch_mlir.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ on:
workflow_dispatch:
inputs:
bump_target:
description: 'Commit hash or branch to bump the submodule to'
description: "Commit hash or branch to bump the submodule to"
required: false
default: 'origin/main'
default: "origin/main"
pull_request:
branches:
- main
Expand All @@ -31,7 +31,7 @@ jobs:
runs-on: ubuntu-20.04
steps:
- name: Checkout repository
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
with:
submodules: false

Expand Down Expand Up @@ -67,9 +67,9 @@ jobs:
base: main
branch: integrates/torch-mlir
delete-branch: true # automatically supercedes the previous bump
title: 'Bump torch-mlir submodule to ${{ steps.bump_submodule.outputs.TORCH_MLIR_COMMIT }}'
title: "Bump torch-mlir submodule to ${{ steps.bump_submodule.outputs.TORCH_MLIR_COMMIT }}"
body: |
This PR updates the torch-mlir submodule to https://github.com/llvm/torch-mlir/commit/${{ steps.bump_submodule.outputs.TORCH_MLIR_COMMIT }}.
Auto-generated by GitHub Actions using `.github/workflows/bump_torch_mlir.yml`.
commit-message: 'Bump torch-mlir submodule to ${{ steps.bump_submodule.outputs.TORCH_MLIR_COMMIT }}'
commit-message: "Bump torch-mlir submodule to ${{ steps.bump_submodule.outputs.TORCH_MLIR_COMMIT }}"
38 changes: 19 additions & 19 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
BUILD_DIR: build-arm64
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
with:
submodules: true
- name: "Building IREE"
Expand Down Expand Up @@ -117,7 +117,7 @@ jobs:
# BUILD_DIR: build-windows
# steps:
# - name: "Checking out repository"
# uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
# uses: actions/checkout@v4.1.7
# with:
# submodules: true
# - id: "gcp-auth"
Expand Down Expand Up @@ -162,7 +162,7 @@ jobs:
BUILD_DIR: build-macos
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Updating git submodules"
run: git submodule update --init --jobs 8 --depth 1
- name: "Installing Python packages"
Expand Down Expand Up @@ -199,7 +199,7 @@ jobs:
shell: bash
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- id: "gcp-auth"
name: "Authenticating to Google Cloud"
if: needs.setup.outputs.write-caches == 1
Expand Down Expand Up @@ -250,7 +250,7 @@ jobs:
- os-family=Linux
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
with:
submodules: true
- name: "Building with Bazel"
Expand Down Expand Up @@ -282,7 +282,7 @@ jobs:
- os-family=Linux
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: Querying GPU information
Expand Down Expand Up @@ -346,7 +346,7 @@ jobs:
- os-family=Linux
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: Querying GPU information
Expand Down Expand Up @@ -406,7 +406,7 @@ jobs:
runs-on: nodai-amdgpu-mi250-x86-64
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: "Downloading install dir archive"
Expand Down Expand Up @@ -445,7 +445,7 @@ jobs:
runs-on: nodai-amdgpu-w7900-x86-64
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: "Downloading install dir archive"
Expand Down Expand Up @@ -505,7 +505,7 @@ jobs:
CONTAINER: ${{ matrix.container }}
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh

Expand Down Expand Up @@ -555,7 +555,7 @@ jobs:
run: |
docker pull ghcr.io/nod-ai/manylinux_x86_64:main &
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
with:
submodules: true
- name: "Setting up Python"
Expand Down Expand Up @@ -632,7 +632,7 @@ jobs:
script: ./build_tools/cmake/build_and_test_tsan.sh
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
with:
submodules: true
- name: "Building and testing"
Expand All @@ -658,7 +658,7 @@ jobs:
BUILD_DIR: build-runtime
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: "Building size-optimized runtime"
Expand Down Expand Up @@ -687,7 +687,7 @@ jobs:
BUILD_DIR: build-gcc
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
with:
submodules: true
- name: "Building IREE with gcc"
Expand Down Expand Up @@ -715,7 +715,7 @@ jobs:
BUILD_DIR: build-tracing
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: "Building IREE runtime with tracing - Tracy"
Expand Down Expand Up @@ -746,7 +746,7 @@ jobs:
BUILD_DIR: build-debug
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
with:
submodules: true
- name: "Building IREE in Debug configuration"
Expand Down Expand Up @@ -774,7 +774,7 @@ jobs:
- os-family=Linux
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
with:
submodules: true
- name: "Building and testing with bring-your-own-LLVM"
Expand Down Expand Up @@ -843,7 +843,7 @@ jobs:
IREE_WRITE_REMOTE_CCACHE: ${{ needs.setup.outputs.write-caches }}
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: "Checking out runtime submodules"
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: "Downloading install dir archive"
Expand Down Expand Up @@ -938,7 +938,7 @@ jobs:
- build_and_test_android
steps:
- name: "Checking out repository"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
uses: actions/checkout@v4.1.7
- name: Getting failed jobs
id: failed_jobs
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
runs-on: ubuntu-20.04
steps:
- name: Checking out repository
uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3 # v3.5.0
uses: actions/checkout@v4.1.7
- name: Setting up python
uses: actions/setup-python@d27e3f3d7c64b4bbf8e4abfb9b63b83e846e0435 # v4.5.0
- name: Running pre-commit
Expand All @@ -28,7 +28,7 @@ jobs:
runs-on: ubuntu-20.04
steps:
- name: Checking out repository
uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3 # v3.5.0
uses: actions/checkout@v4.1.7
- name: Generating CMake files
run: |
./build_tools/scripts/generate_cmake_files.sh
Expand Down
Loading

0 comments on commit 1997902

Please sign in to comment.