Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StableHLO] Port mhlo tests to stablehlo #13869

Closed
25 tasks done
kuhar opened this issue May 31, 2023 · 0 comments · Fixed by #13916
Closed
25 tasks done

[StableHLO] Port mhlo tests to stablehlo #13869

kuhar opened this issue May 31, 2023 · 0 comments · Fixed by #13916
Assignees
@kuhar
Labels
integrations/stablehlo StableHLO (JAX/TensorFlow/etc) import and conversion

Comments

@kuhar
Copy link
Member

kuhar commented May 31, 2023 •
edited
Loading

There are a lot of existing non-mhlo specific tests in the source tree that need to be ported to operate on stablehlo before we can drop mhlo input conversion support:

➜ ~/iree/iree git:(main) 
$ rg '=mhlo[^_]' --files-with-matches
  • experimental/web/sample_dynamic/build_sample.sh
  • experimental/web/sample_static/build_sample.sh
  • samples/colab/edge_detection.ipynb
  • samples/colab/mnist_training.ipynb
  • samples/dynamic_shapes/test.sh
  • samples/dynamic_shapes/README.md
  • samples/models/mnist.mlir
  • samples/variables_and_state/variables_and_state.ipynb
  • samples/vision_inference/README.md
  • tests/e2e/models/BUILD.bazel
  • tests/e2e/models/CMakeLists.txt
  • tests/e2e/models/collatz.mlir
  • tests/e2e/models/edge_detection.mlir
  • tests/e2e/models/fragment_000.mlir
  • tests/e2e/models/fullyconnected.mlir
  • tests/e2e/models/mnist_fake_weights.mlir
  • tests/e2e/models/resnet50_fake_weights.mlir
  • tests/e2e/models/unidirectional_lstm.mlir
  • tests/e2e/regression/BUILD.bazel
  • tests/e2e/regression/CMakeLists.txt
  • tests/e2e/regression/globals_ml_program.mlir
  • tests/e2e/regression/trace_dispatch_tensors.mlir
  • tests/e2e/vulkan_specific/BUILD.bazel
  • tests/e2e/vulkan_specific/CMakeLists.txt
    - [ ] tests/e2e/xla_ops/BUILD.bazel
    - [ ] tests/e2e/xla_ops/CMakeLists.txt
  • tests/microbenchmarks/CMakeLists.txt

There should be some semi-mechanical way to convert mhlo to stablehlo but do not run any other passes.

Parent issue: #12678
@kuhar kuhar added the integrations/stablehlo StableHLO (JAX/TensorFlow/etc) import and conversion label May 31, 2023
@kuhar kuhar self-assigned this May 31, 2023
@kuhar kuhar mentioned this issue May 31, 2023
Closed
kuhar added a commit to kuhar/iree that referenced this issue May 31, 2023
@kuhar
Deprecate MHLO input conversion pipeline
2e25574 
As we continue the migration to the stablehlo input conversion pipeline,
mark the mhlo pipeline as deprecated and rename the option to
`--iree-input-type=mhlo_legacy`.

This was proposed and announced in the following RFC:
https://groups.google.com/g/iree-discuss/c/s6dBpDtWhtk.

Users are encouraged to try the new pipeline:
`--iree-input-type=stablehlo` and report any issues or missing features,
as we plan to drop the legacy mhlo pipeline in a few weeks.

Update tests to use the new flag name. Update documents to suggest
either the new pipeline or the new flag.

Next, we will have to migrate existing test and samples to use
StableHLO as the input format:
iree-org#13869.

Issue: iree-org#12678
@kuhar kuhar mentioned this issue May 31, 2023
Merged
kuhar added a commit that referenced this issue Jun 1, 2023
@kuhar
Deprecate MHLO input conversion pipeline (#13870)
950e172 
As we continue the migration to the stablehlo input conversion pipeline,
mark the mhlo pipeline as deprecated and rename the option to
`--iree-input-type=mhlo_legacy`.

This was proposed and announced in the following RFC:
https://groups.google.com/g/iree-discuss/c/s6dBpDtWhtk.

Users are encouraged to try the new pipeline:
`--iree-input-type=stablehlo` and report any issues or missing features,
as we plan to drop the legacy mhlo pipeline in a few weeks.

Update tests to use the new flag name. Update documents to suggest
either the new pipeline or the new flag.

Next, we will have to migrate existing test and samples to use StableHLO
as the input format:
#13869.

Issue: #12678
kuhar added a commit to kuhar/iree that referenced this issue Jun 1, 2023
@kuhar
[StableHLO] Add pass to convert from MHLO to StableHLO
fbc315f 
This is to aid in the migration of existing MHLO-based tests.

Issue: iree-org#13869
@kuhar kuhar mentioned this issue Jun 1, 2023
Merged
kuhar added a commit that referenced this issue Jun 1, 2023
@kuhar
[StableHLO] Add pass to convert from MHLO to StableHLO (#13896)
4a9e22f 
This is to aid in the migration of existing MHLO-based tests. The pass
is expected to be short-lived and removed when we drop mhlo support.

The pass is available using a new flag `iree-opt --iree-convert-mhlo-to-stablehlo`.

Issue: #13869
kuhar added a commit to kuhar/iree that referenced this issue Jun 2, 2023
@kuhar
[StableHLO] Migrate samples to StableHLO
49f155f 
Tested by running all notebooks locally.

The mnist model was converted using
`iree-opt --iree-convert-mhlo-to-stablehlo`.

Issue: iree-org#13869
@kuhar kuhar mentioned this issue Jun 2, 2023
Merged
kuhar added a commit to kuhar/iree that referenced this issue Jun 2, 2023
@kuhar
[StableHLO] Migrate vulkan-specific tests to StableHLO
e6123e4 
Issue: iree-org#13869
@kuhar kuhar mentioned this issue Jun 2, 2023
Merged
kuhar added a commit that referenced this issue Jun 2, 2023
@kuhar
[StableHLO] Migrate vulkan-specific tests to StableHLO (#13925)
812eac9 
Issue: #13869
kuhar added a commit to kuhar/iree that referenced this issue Jun 2, 2023
@kuhar
[StableHLO] Migrate regression tests and microbenchmarks to StableHLO
d784962 
Issue: iree-org#13869
@kuhar kuhar mentioned this issue Jun 2, 2023
Merged
kuhar added a commit to kuhar/iree that referenced this issue Jun 2, 2023
@kuhar
[StableHLO] Migrate e2e models to StableHLO
3cf13ee 
Upgraded using `iree --iree-convert-mhlo-to-stablehlo`.

Issue: iree-org#13869
@kuhar kuhar mentioned this issue Jun 2, 2023
Merged
kuhar added a commit that referenced this issue Jun 2, 2023
@kuhar
[StableHLO] Migrate regression tests and microbenchmarks to StableHLO (…
224caae 
…#13928)

Issue: #13869
kuhar added a commit that referenced this issue Jun 2, 2023
@kuhar
[StableHLO] Migrate e2e models to StableHLO (#13929)
efb045e 
Upgraded using `iree-opt --iree-convert-mhlo-to-stablehlo`.

Issue: #13869
kuhar added a commit to kuhar/iree that referenced this issue Jun 2, 2023
@kuhar
[StableHLO] Migrate samples to StableHLO
9931f2a 
Tested by running all notebooks locally.

The mnist model was converted using
`iree-opt --iree-convert-mhlo-to-stablehlo`.

Issue: iree-org#13869
jvstokes pushed a commit to jvstokes/iree that referenced this issue Jun 4, 2023
@kuhar @jvstokes
Deprecate MHLO input conversion pipeline (iree-org#13870)
6809ca9 
As we continue the migration to the stablehlo input conversion pipeline,
mark the mhlo pipeline as deprecated and rename the option to
`--iree-input-type=mhlo_legacy`.

This was proposed and announced in the following RFC:
https://groups.google.com/g/iree-discuss/c/s6dBpDtWhtk.

Users are encouraged to try the new pipeline:
`--iree-input-type=stablehlo` and report any issues or missing features,
as we plan to drop the legacy mhlo pipeline in a few weeks.

Update tests to use the new flag name. Update documents to suggest
either the new pipeline or the new flag.

Next, we will have to migrate existing test and samples to use StableHLO
as the input format:
iree-org#13869.

Issue: iree-org#12678
kuhar added a commit that referenced this issue Jun 5, 2023
@kuhar
[StableHLO] Migrate samples to StableHLO (#13916)
df71589 
Tested by running all notebooks locally.

The mnist model was converted using
`iree-opt --iree-convert-mhlo-to-stablehlo`.

Fixes: #13869
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this issue Jul 6, 2023
@kuhar @NatashaKnk
Deprecate MHLO input conversion pipeline (iree-org#13870)
4aa0d71 
As we continue the migration to the stablehlo input conversion pipeline,
mark the mhlo pipeline as deprecated and rename the option to
`--iree-input-type=mhlo_legacy`.

This was proposed and announced in the following RFC:
https://groups.google.com/g/iree-discuss/c/s6dBpDtWhtk.

Users are encouraged to try the new pipeline:
`--iree-input-type=stablehlo` and report any issues or missing features,
as we plan to drop the legacy mhlo pipeline in a few weeks.

Update tests to use the new flag name. Update documents to suggest
either the new pipeline or the new flag.

Next, we will have to migrate existing test and samples to use StableHLO
as the input format:
iree-org#13869.

Issue: iree-org#12678
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this issue Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO] Add pass to convert from MHLO to StableHLO (iree-org#13896)
cb95e7c 
This is to aid in the migration of existing MHLO-based tests. The pass
is expected to be short-lived and removed when we drop mhlo support.

The pass is available using a new flag `iree-opt --iree-convert-mhlo-to-stablehlo`.

Issue: iree-org#13869
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this issue Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO] Migrate vulkan-specific tests to StableHLO (iree-org#13925)
f2044bc 
Issue: iree-org#13869
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this issue Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO] Migrate regression tests and microbenchmarks to StableHLO (…
3fe2c90 
…iree-org#13928)

Issue: iree-org#13869
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this issue Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO] Migrate e2e models to StableHLO (iree-org#13929)
ab71254 
Upgraded using `iree-opt --iree-convert-mhlo-to-stablehlo`.

Issue: iree-org#13869
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this issue Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO] Migrate samples to StableHLO (iree-org#13916)
afe2991 
Tested by running all notebooks locally.

The mnist model was converted using
`iree-opt --iree-convert-mhlo-to-stablehlo`.

Fixes: iree-org#13869
nhasabni pushed a commit to plaidml/iree that referenced this issue Aug 24, 2023
@kuhar @nhasabni
Deprecate MHLO input conversion pipeline (iree-org#13870)
aec4254 
As we continue the migration to the stablehlo input conversion pipeline,
mark the mhlo pipeline as deprecated and rename the option to
`--iree-input-type=mhlo_legacy`.

This was proposed and announced in the following RFC:
https://groups.google.com/g/iree-discuss/c/s6dBpDtWhtk.

Users are encouraged to try the new pipeline:
`--iree-input-type=stablehlo` and report any issues or missing features,
as we plan to drop the legacy mhlo pipeline in a few weeks.

Update tests to use the new flag name. Update documents to suggest
either the new pipeline or the new flag.

Next, we will have to migrate existing test and samples to use StableHLO
as the input format:
iree-org#13869.

Issue: iree-org#12678
nhasabni pushed a commit to plaidml/iree that referenced this issue Aug 24, 2023
@kuhar @nhasabni
[StableHLO] Add pass to convert from MHLO to StableHLO (iree-org#13896)
fe070bf 
This is to aid in the migration of existing MHLO-based tests. The pass
is expected to be short-lived and removed when we drop mhlo support.

The pass is available using a new flag `iree-opt --iree-convert-mhlo-to-stablehlo`.

Issue: iree-org#13869
nhasabni pushed a commit to plaidml/iree that referenced this issue Aug 24, 2023
@kuhar @nhasabni
[StableHLO] Migrate vulkan-specific tests to StableHLO (iree-org#13925)
82103ec 
Issue: iree-org#13869
nhasabni pushed a commit to plaidml/iree that referenced this issue Aug 24, 2023
@kuhar @nhasabni
[StableHLO] Migrate regression tests and microbenchmarks to StableHLO (…
a5d6458 
…iree-org#13928)

Issue: iree-org#13869
nhasabni pushed a commit to plaidml/iree that referenced this issue Aug 24, 2023
@kuhar @nhasabni
[StableHLO] Migrate e2e models to StableHLO (iree-org#13929)
1d71d3f 
Upgraded using `iree-opt --iree-convert-mhlo-to-stablehlo`.

Issue: iree-org#13869
nhasabni pushed a commit to plaidml/iree that referenced this issue Aug 24, 2023
@kuhar @nhasabni
[StableHLO] Migrate samples to StableHLO (iree-org#13916)
67e55d9 
Tested by running all notebooks locally.

The mnist model was converted using
`iree-opt --iree-convert-mhlo-to-stablehlo`.

Fixes: iree-org#13869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuhar kuhar

Labels
integrations/stablehlo StableHLO (JAX/TensorFlow/etc) import and conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[StableHLO] Migrate samples to StableHLO kuhar/iree
1 participant
@kuhar