[StableHLO] Use stablehlo submodule #14094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhar
requested review from
MaheshRavishankar,
stellaraccident,
benvanik,
GMNGeoffrey,
ScottTodd and
pzread
as code owners
kuhar
commented
Jun 13, 2023
kuhar
force-pushed
the
stablehlo-submodule
branch
from
543eea5
to
ee2a2c8
Compare
kuhar
changed the title
kuhar
force-pushed
the
stablehlo-submodule
branch
from
c6ca08b
to
cd90cbf
Compare
Use the stablehlo submodule to provide stablehlo, since we do not need the 'mhlo' part or mlir-hlo anymore.
kuhar
force-pushed
the
stablehlo-submodule
branch
from
cd90cbf
to
c1f7c7a
Compare
|
The failing lint check is for some existing issues in |
|
Ping |
ScottTodd
reviewed
Jun 14, 2023
|
CODEOWNERS added lots of reviewers for this. I pruned the list a bit, but it might also help to do that sooner / explicitly say who you expect reviews from. |
antiagainst
approved these changes
Jun 14, 2023
|
Wow this is awesome! Very happy to know that this works seamlessly after openxla/stablehlo#1612. |
ScottTodd
added
the
integrations/stablehlo
Co-authored-by: Scott Todd <scotttodd@google.com>
ScottTodd
approved these changes
Jun 14, 2023
|
Awesome, congrats!! |
nhasabni
pushed a commit
to plaidml/iree
that referenced
this pull request
Aug 24, 2023
Use the stablehlo submodule to provide stablehlo, since we do not need the 'mhlo' part or mlir-hlo anymore. Fixes: iree-org#12678 --------- Co-authored-by: Scott Todd <scotttodd@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the stablehlo submodule to provide stablehlo, since we do not need the 'mhlo' part or mlir-hlo anymore.
Fixes: #12678