[CMake] Make StableHLO build consistent with MLIR-HLO #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies when stablehlo is built by other projects enabled as an external llvm project. This change makes it match the mlir-hlo configuration more closely: https://github.com/tensorflow/mlir-hlo/blob/51ce2fa22bc9acff37332ad02ef39412f21ffc98/CMakeLists.txt#L113-L130, and ease the transition from mlir-hlo to stablehlo: https://discourse.llvm.org/t/sunsetting-the-mlir-hlo-repository/70536. Tested by embeding stablehlo into IREE. q
kuhar
changed the title
burmako
changed the title
burmako
approved these changes
Jun 13, 2023
| @@ -37,19 +37,27 @@ endif() | |||
| #------------------------------------------------------------------------------- | |||
| # Options and settings | |||
| #------------------------------------------------------------------------------- | |||
| option(STABLEHLO_BUILD_EMBEDDED "Build StableHLO as part of another project" OFF) | |||
There was a problem hiding this comment.
There are quite a few related boolean variables - STABLEHLO_BUILD_EMBEDDED, STABLEHLO_STANDALONE_BUILD and STABLEHLO_EXTERNAL_PROJECT_BUILD - and I think that not all combinations of them are valid, so it's a bit confusing.
However, given that this PR aims to exactly reproduce the MLIR-HLO setup, I think we should keep these variables as is to first establish the baseline and then think about refining it. I'll maybe look into this in a follow-up PR.
This was referenced Jun 14, 2023
burmako
pushed a commit
that referenced
this pull request
Jun 23, 2023
To follow up on #1612, this PR further aligns StableHLO and MLIR-HLO builds to facilitate the transition from mlir-hlo to stablehlo. Changes in this PR: 1) Adds Ccache support. 2) Adds support for LLVM_ENABLE_ZLIB. 3) Removes STABLEHLO_STANDALONE_BUILD, to better align with MLIR-HLO terminology. Deltas between CMakeLists.txt in this PR and CMakeLists.txt in MLIR-HLO: a) Says "StableHLO" instead of "MHLO". b) Supports STABLEHLO_ENABLE_STRICT_BUILD (there is no equivalent in the MLIR-HLO build). c) Doesn't support ${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules yet, as well as some MLIR_HLO_FOO_DIR variables needed for that. (We have #1549 to follow up on this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies when stablehlo is built by other projects enabled as an
external llvm project.
This change makes it match the mlir-hlo configuration more closely:
https://github.com/tensorflow/mlir-hlo/blob/51ce2fa22bc9acff37332ad02ef39412f21ffc98/CMakeLists.txt#L113-L130,
and ease the transition from mlir-hlo to stablehlo:
https://discourse.llvm.org/t/sunsetting-the-mlir-hlo-repository/70536.
Tested by embedding stablehlo into IREE.
Issue: #1549