Make LLD truly optional. #15580
Merged
Make LLD truly optional. #15580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellaraccident
requested review from
benvanik,
ScottTodd and
pzread
as code owners
benvanik
approved these changes
Nov 14, 2023
hcindyl
reviewed
Nov 14, 2023
ScottTodd
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Cool! I actually tried cross compiling IREE's compiler to WebAssembly again recently and the unconditional lld dep blocked me: https://gist.github.com/ScottTodd/7898981998cefb60902d4fbc8a471ccf?permalink_comment_id=4744106#gistcomment-4744106 (not sure if an emscripten build of lld is easy/possible)
Could try that again with this patch 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.