[DT] Make the padding sizes of encodings be a scalar. #17601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lialan
requested review from
hanhanW,
MaheshRavishankar and
benvanik
as code owners
lialan
force-pushed
the
lialan/refactor_round_dims_to
branch
2 times, most recently
from
fe352e0
to
621de06
Compare
bjacob
reviewed
Jun 7, 2024
compiler/src/iree/compiler/Codegen/Common/CPU/CPUMaterializeEncodingPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/CPU/CPUMaterializeEncodingPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/CPU/CPUMaterializeEncodingPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/CPU/CPUMaterializeEncodingPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/CPU/CPUMaterializeEncodingPass.cpp
Outdated
Show resolved
Hide resolved
lialan
force-pushed
the
lialan/refactor_round_dims_to
branch
2 times, most recently
from
16c8878
to
5451e76
Compare
bjacob
reviewed
Jun 7, 2024
compiler/src/iree/compiler/Codegen/Common/CPU/CPUMaterializeEncodingPass.cpp
Outdated
Show resolved
Hide resolved
lialan
force-pushed
the
lialan/refactor_round_dims_to
branch
from
5451e76
to
30a172e
Compare
bjacob
reviewed
Jun 7, 2024
lialan
force-pushed
the
lialan/refactor_round_dims_to
branch
from
30a172e
to
08bd8f5
Compare
hanhanW
reviewed
Jun 10, 2024
compiler/src/iree/compiler/Codegen/Common/MaterializeEncodingIntoPackUnPack.cpp
Outdated
Show resolved
Hide resolved
lialan
force-pushed
the
lialan/refactor_round_dims_to
branch
2 times, most recently
from
8bff133
to
5b264db
Compare
@hanhanW I it is much better to do in this way. I will do a subsequent PR for it later. For now just leave it as is. |
lialan
force-pushed
the
lialan/refactor_round_dims_to
branch
from
5b264db
to
c833f1c
Compare
hanhanW
approved these changes
Jun 10, 2024
lialan
force-pushed
the
lialan/refactor_round_dims_to
branch
from
c833f1c
to
f480278
Compare
hanhanW
changed the title
round_dims_to
|
@lialan I took a stab at better PR title and linked the related issue to the PR description. Feel free to make it better if you got some ideas. (I'm not good at naming.) |
lialan
force-pushed
the
lialan/refactor_round_dims_to
branch
3 times, most recently
from
aa57d25
to
19d9d95
Compare
* rename `round_dims_to` to `max_padding` * make `max_padding` a generic case single value attribute Signed-off-by: Alan Li <me@alanli.org>
lialan
force-pushed
the
lialan/refactor_round_dims_to
branch
from
19d9d95
to
cefe0c2
Compare
|
Dropping this in favor of #17729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
round_dims_totomax_paddingmax_paddinga generic case single value attributeProgress towards #17553