[GPUDistributionPatterns] Propagate predicate attribute for cmpf op #17664
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aviator19941
force-pushed
the
gpu_predicate_pattern
branch
3 times, most recently
from
46a35ba
to
ab4dbb0
Compare
compiler/src/iree/compiler/Codegen/Common/GPU/test/gpu_vector_distribution.mlir
Outdated
Show resolved
Hide resolved
|
@Groverkss this is running into the issue I had brought up before with this pattern. By not cloning the operation we end up dropping important attributes like this. I think this needs to become a clone of the op and then any distribution related attrs are removed after the clone. |
There was a problem hiding this comment.
Instead of setting attributes one-by-one, can we clone the operation instead? @qedawkins I had issues with that before, but not anymore, as @raikonenfnu found a better way around my issues.
yeah I can try to clone the operation instead. |
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
aviator19941
force-pushed
the
gpu_predicate_pattern
branch
from
d195d9f
to
6844649
Compare
compiler/src/iree/compiler/Codegen/Common/GPU/test/gpu_vector_distribution.mlir
Show resolved
Hide resolved
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
…ree-org#17664) We aren't propagating the predicate attribute for cmpf if it is there, this fixes the missing predicate attribute for cmpf. --------- Signed-off-by: aviator19941 <avinash.sharma@amd.com> Signed-off-by: Lubo Litchev <lubol@google.com>
We aren't propagating the predicate attribute for cmpf if it is there, this fixes the missing predicate attribute for cmpf.