[NFC][Flow] Remove use of fusion preprocessing when it isnt a preprocessing #17899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essing. The Fusion preprocessing pass was used in multiple places, which is not the intent of the pass. Remove the subsequent usage. The only reason for this double usage was for the pattern that moved reduction dimensions to the innermost. Consolidate that pattern with the pattern in `InterchangeTransposeGenericPass` (whose name is very convoluted and does not represent what it actually does). Rename `InterchangeTransposeGenericPass` to `TransposeGenericOpsPass`. Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
MaheshRavishankar
requested review from
qedawkins,
benvanik,
IanWood1 and
hanhanW
and removed request for
hanhanW,
qedawkins and
benvanik
|
Could help to review one commit at a time. |
MaheshRavishankar
added
benchmarks:cuda
qedawkins
approved these changes
Jul 14, 2024
MaheshRavishankar
removed
benchmarks:android-cpu
Also reoder the passes in `Passes.td` to be alphabetical within each of the following portions - Dispatch region preprocessing passes - Dispatch region formation passes - General flow passes. Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
MaheshRavishankar
force-pushed
the
nfc_fix_fusion_preprocessing_use
branch
from
0fe46dd
to
bc054b6
Compare
Abbreviated Benchmark Summary@ commit 8a92b42503a3e4ecd793ff97ac417ce2d908d201 (vs. base a56975ddba226748b3e59efbc879a250b02147fa) Data-Tiling Comparison TableClick to show
No improved or regressed benchmarks 🏖️ No improved or regressed compilation metrics 🏖️ For more information: |
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
…essing (iree-org#17899) The Fusion preprocessing pass was used in multiple places, which is not the intent of the pass. Remove the subsequent usage. The only reason for this double usage was for the pattern that moved reduction dimensions to the innermost. Consolidate that pattern with the pattern in `InterchangeTransposeGenericPass` (whose name is very convoluted and does not represent what it actually does). This commit also includes the following changes: - Rename `InterchangeTransposeGenericPass` to `TransposeGenericOpsPass`. - Reoder the passes in `Passes.td` to be alphabetical within each of the following portions - Dispatch region preprocessing passes - Dispatch region formation passes - General flow passes. --------- Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com> Signed-off-by: Lubo Litchev <lubol@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fusion preprocessing pass was used in multiple places, which is
not the intent of the pass. Remove the subsequent usage. The only
reason for this double usage was for the pattern that moved reduction
dimensions to the innermost. Consolidate that pattern with the pattern
in
InterchangeTransposeGenericPass(whose name is very convolutedand does not represent what it actually does).
This commit also includes the following changes:
InterchangeTransposeGenericPasstoTransposeGenericOpsPass.Passes.tdto be alphabetical within each of the followingportions