[Codegen][GPU] Add pass to expand multi_mma op shapes to intrinsic layout #18139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yout Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
qedawkins
reviewed
Aug 7, 2024
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/ConcretizeMmaShapes.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
qedawkins
reviewed
Aug 7, 2024
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/ConcretizeMmaShapes.cpp
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/ConcretizeMmaShapes.cpp
Outdated
Show resolved
Hide resolved
| let dependentDialects = [ | ||
| "::mlir::tensor::TensorDialect", | ||
| "::mlir::iree_compiler::IREE::GPU::IREEGPUDialect", | ||
| "::mlir::iree_compiler::IREE::VectorExt::IREEVectorExtDialect", |
There was a problem hiding this comment.
Why do we need a VectorExt dep here?
There was a problem hiding this comment.
getConcreteMFMALayout generates some PerDimLayoutAttr which are unused, but I didn't want to refactor the whole function, so I just added the dependent dialect.
There was a problem hiding this comment.
gah, that's a pain. Can you add a TODO somewhere to drop that dependency?
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/ConcretizeMmaShapes.cpp
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/ConcretizeMmaShapes.cpp
Show resolved
Hide resolved
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
qedawkins
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new pass to explicitly materialize the dimensions of intrinsic layouts for
iree_gpu.multi_mmaops. This means adding an expand_shape on each of the inputs to go from theOpaqueMmaLayoutshape to theConcreteMmaLayoutshape. This makes it easy to extract the correct data from the tensors when it is time to distribute the multi_mma op to lanes, since the shape will match the number of offsets and sizes needed for the slice.