New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor match() to use bytes.Equal for better performance #6

Merged

irfansharif merged 1 commit into irfansharif:master from SchumacherFM:refactor-match

Aug 7, 2016

Contributor

SchumacherFM commented Aug 7, 2016

type fingerprint []byte and []byte have the same memory layout hence bytes.Equal can be used without type casting.


          Refactor match() to use bytes.Equal for better performance

e4f12f6

irfansharif merged commit c3db6c3 into irfansharif:master

Owner

irfansharif commented Aug 7, 2016

good catch! i was averse to using reflect.DeepEqual(a, b interface{}) but didn't realise there was another alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet