shellcheck changes broke bash 3.2 and 4.4 completion and zsh '-c' flag.

[jshort]

Hi,

I'm working on #7 and right before pushing my changes to my fork, I pulled the latest changes from the upstream and found that

dae1cbd

Has broken bash 3.2 (default on MacOS), bash 4.4 completion, and the -c flag (because of mapfile) for zsh.

Can we try to keep this code bash/zsh agnostic. The shellcheck gripes do offer options that don't use mapfile (only in bash 4 and above).

As to why completion is broken in bash 4.4, I'm not sure. It seems that it is trying to execute the cmd of the discovered aliases, not present them to the shell.

[iridakos]

Hi @jshort and thanks for reporting!

If I understand correctly, all the problems you described are caused due to the usage of mapfile?

[jshort]

Just doing some debugging of the the completion problem in bash 4.4.

It only occurs if you do

goto <TAB>

bash-4.4$ goto bash: wp: command not found
bash: blah: command not found
bash: another: command not found
bash: yo: command not found

however, this works and completes:

goto w<TAB>

[iridakos]

Can you please pull from upstream and check if the mapfile problems are fixed?

[jshort]

So that change fixes some aspects of completion for bash 3.2.

However, the case for when you hit without even typing any characters (where you'd expect the completion logic to present you with all of the alias as options) is still not working in both bash 3.2 and 4.4.

Note there is one more mapfile in the cleanup logic. Also ${!array[@]} does not work in zsh to get the indexes. I suppose we can do for i in {0..${#matches}; do ?

[iridakos]

However, the case for when you hit without even typing any characters (where you'd expect the completion logic to present you with all of the alias as options) is still not working in both bash 3.2 and 4.4.

It should be fine now.

Note there is one more mapfile in the cleanup logic.

Fixed that too.

Also ${!array[@]} does not work in zsh to get the indexes. I suppose we can do for i in {0..${#matches}; do ?

That's your call for the time being... I am very newbie to zsh...

[jshort]

Ok completion is fine now. What was the MacOS specific change needed in that last commit. The commit that worked last night (eb01f9c) seemed to have the same logic other than the double quotes.

[iridakos]

The problem was here:

al=$("${matches[$i]// */}")

As you can see, we request execution with the outer $(). So, each aliases deriving from "${matches[$i]// */}" was treated as command.

I'm closing the issue but feel free to report whatever you see.

Thank you very much for the feedback!!!