Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Turn on gn check for libassistant/*."
This reverts commit 23aaa1a. Reason for revert: gn check failing since https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/7336 Errors like Step _generate_buildfiles failed. Error logs are shown below: ERROR at //libassistant/shared/internal_api/c/public/logging.h:8:11: Include not allowed. #include "base/logging.h" ^------------- It is not in any dependency of //libassistant/shared/internal_api/c:api_wrappers The include file is in the target(s): //base:base which should somehow be reachable. ___________________ ERROR at //libassistant/shared/utils/net/http_connection_utils.h:12:11: Can't include this header from here. #include "libassistant/shared/internal_api/http_connection.h" ^------------------------------------------------- The target: //libassistant/shared/utils:http_connection_utils is including a file from the target: BUG=1010814 Original change's description: > Turn on gn check for libassistant/*. > > Merge-With: libassistant-internal/109915 > Merge-With: libassistant-internal/109885 > > Bug: Internal b/130382048 > Test: gn check libassistant build with two listed patches > Change-Id: Id30a100aad39caa8b149b81bf90da81db877b104 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817418 > Auto-Submit: Simeon Anfinrud <sanfin@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702256} TBR=halliwell@chromium.org,sanfin@chromium.org,jbudorick@chromium.org,danielkay@google.com Change-Id: Ib988b21d930038b9045951628fe0ea5fff56dc2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: Internal b/130382048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837448 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#702346}
- Loading branch information