Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Use redux container for ad slot #183

Merged
merged 5 commits into from
Oct 26, 2016
Merged

[RFR] Use redux container for ad slot #183

merged 5 commits into from
Oct 26, 2016

Conversation

eschaefer
Copy link
Contributor

@eschaefer eschaefer commented Oct 25, 2016 •
edited
Loading

Moves mapping the currentcity data into a container component rather than drilling props into <AdSlot> every time it's called.

@artibella artibella temporarily deployed to iris-frontend-dev-pr-183 October 25, 2016 10:41 Inactive
@eschaefer eschaefer mentioned this pull request Oct 25, 2016
Merged
5 tasks
@artibella artibella temporarily deployed to iris-frontend-dev-pr-183 October 25, 2016 10:53 Inactive
@artibella artibella temporarily deployed to iris-frontend-dev-pr-183 October 25, 2016 11:49 Inactive
@eschaefer
Copy link
Contributor Author

@mattberridge @artibella just fyi

@eschaefer eschaefer merged commit 5759291 into develop Oct 26, 2016
@mattboon mattboon deleted the feature/adslot-container branch January 18, 2017 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eschaefer @artibella