[irods/irods#5479] Port krb plugin to new framework (main) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korydraughn
reviewed
May 2, 2022
|
I have addressed the remaining non-resolved comments but this is now dependent on the non-pam changes in irods/irods#6358 (as well as some others which have not yet been pushed). I'll try to get that PR prepared for merge so that we can do this one as well. Once that is done, I can resolve the open comments. |
|
Okay, the linked PR has been merged. Any other comments, @korydraughn / @trel ? |
|
If the tests pass, then I think we're ready to go on and merge this. |
korydraughn
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds and passes tests, but I would like to spend some more time making sure that it's... y'know, good. Maybe even add more tests. Just putting it up here for your viewing pleasure.