Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test hook and basic tests #6

Closed
2 tasks done
alanking opened this issue Feb 12, 2024 · 3 comments
Closed
2 tasks done

Add test hook and basic tests #6

alanking opened this issue Feb 12, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@alanking
Copy link
Contributor

alanking commented Feb 12, 2024

  • Test hook
  • Some basic tests
@alanking alanking added this to the 4.3.1.0 milestone Feb 21, 2024
@alanking alanking self-assigned this Aug 2, 2024
@alanking
Copy link
Contributor Author

alanking commented Aug 2, 2024

For now, let's not plan on using pam_python or any other custom PAM modules. We discovered a while back that it requires python2 and it doesn't seem to be actively maintained, so we probably don't want to lean on it in our testing. Plus, we have successfully demonstrated working auth flows using standard PAM modules, so we can write tests based on these.

To start, we will emulate pam_password in our testing. We can move to other modules (e.g. pam_permit, pam_deny) for testing purposes by leveraging the assumed root powers of running the test hook and modifying the "irods" stack.

Further down the road, we can make the plugin's PAM stack configurable (see #37).

alanking added a commit to alanking/irods_auth_plugin_pam_interactive that referenced this issue Aug 6, 2024
This commit adds a test hook script for testing the plugin and an
initial test suite based on the pam_password configuration test suite
in the main iRODS repository.
alanking added a commit that referenced this issue Aug 6, 2024
This commit adds a test hook script for testing the plugin and an
initial test suite based on the pam_password configuration test suite
in the main iRODS repository.
@alanking
Copy link
Contributor Author

alanking commented Aug 6, 2024

Test hook and some basic tests have now been added. Further testing can be added as we add more features. Closing this one.

@alanking alanking closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant