Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several -Wmissing-field-initializers warnings when building against 4.3.1 candidate #168

Open
alanking opened this issue Oct 11, 2023 · 1 comment
Assignees

Comments

@alanking
Copy link
Contributor

Noticed while building against Rocky Linux 9...

Some new members have appeared in our structs, namely:

RcComm::session_signature
RsComm::session_props
rodsEnv::tcp_keepalive_intvl
rodsEnv::tcp_keepalive_probes
rodsEnv::tcp_keepalive_time

These need to be made available in PREP.

@alanking
Copy link
Contributor Author

On that note, there are several entirely new structs that we might need to add as well. Don't have those handy, but I know a few new APIs with special input structures have been introduced in 4.3.1

@alanking alanking self-assigned this Oct 12, 2023
alanking added a commit to alanking/irods_rule_engine_plugin_python that referenced this issue Oct 13, 2023
This was lifted directly from the irods/irods CMakeLists.txt file.
alanking added a commit to alanking/irods_rule_engine_plugin_python that referenced this issue Oct 13, 2023
This warning is raised by a Boost Python header file when newer versions
of Python are used with Boost 1.81. Since there isn't much we can do about
that, we ignore the warning for that header. For more information, see
boostorg/python#418
alanking added a commit to alanking/irods_rule_engine_plugin_python that referenced this issue Oct 13, 2023
This change adds missing check_auth_credentials type.

Adds tcp_keepalive members to rodsEnv as well as connection pool timeout
member which was not added before.

Also added session_signature member of RcComm and session_props member of
RsComm.

-Wmissing-field-initializers is raised by a missing member of sockaddr_in
called sin_zero. This member has been removed in bwg2001-004. For more
information, see http://www.opengroup.org/platform/resolutions/bwg2001-many.html

Even though sin_zero must be included in the member list for sockaddr_in
for a complete member initialization list, we do not expose it as a
property for this type in the rule engine because sin_zero is not part
of the standard and may not be available in the future.

The missing member is included to silence the warning.
alanking added a commit that referenced this issue Oct 13, 2023
This was lifted directly from the irods/irods CMakeLists.txt file.
alanking added a commit that referenced this issue Oct 13, 2023
This warning is raised by a Boost Python header file when newer versions
of Python are used with Boost 1.81. Since there isn't much we can do about
that, we ignore the warning for that header. For more information, see
boostorg/python#418
alanking added a commit that referenced this issue Oct 13, 2023
This change adds missing check_auth_credentials type.

Adds tcp_keepalive members to rodsEnv as well as connection pool timeout
member which was not added before.

Also added session_signature member of RcComm and session_props member of
RsComm.

-Wmissing-field-initializers is raised by a missing member of sockaddr_in
called sin_zero. This member has been removed in bwg2001-004. For more
information, see http://www.opengroup.org/platform/resolutions/bwg2001-many.html

Even though sin_zero must be included in the member list for sockaddr_in
for a complete member initialization list, we do not expose it as a
property for this type in the rule engine because sin_zero is not part
of the standard and may not be available in the future.

The missing member is included to silence the warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant