Add missing types and members (main) #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korydraughn
reviewed
Oct 12, 2023
|
Squashed |
|
I'll open another PR for the additional missing types. |
This was lifted directly from the irods/irods CMakeLists.txt file.
This warning is raised by a Boost Python header file when newer versions of Python are used with Boost 1.81. Since there isn't much we can do about that, we ignore the warning for that header. For more information, see boostorg/python#418
This change adds missing check_auth_credentials type. Adds tcp_keepalive members to rodsEnv as well as connection pool timeout member which was not added before. Also added session_signature member of RcComm and session_props member of RsComm. -Wmissing-field-initializers is raised by a missing member of sockaddr_in called sin_zero. This member has been removed in bwg2001-004. For more information, see http://www.opengroup.org/platform/resolutions/bwg2001-many.html Even though sin_zero must be included in the member list for sockaddr_in for a complete member initialization list, we do not expose it as a property for this type in the rule engine because sin_zero is not part of the standard and may not be available in the future. The missing member is included to silence the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #168
This may not be exhaustive.