Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simulator): miscellaneous cleanup fixes and improvements #3897

Merged
merged 1 commit into from
May 10, 2023

Conversation

holahula
Copy link
Contributor

@holahula holahula commented May 8, 2023

Summary

Adds a few simulator improvements:

  • simulator start now couples in building the root ironfish binary so the simulation running will always track ironfish changes
  • removed util code that just wrapped client calls
  • removed stop command because it was flaky
  • made onLog / onError optional when executing CLI commands, default behaviour is now to log
  • Added a tmp dir @ ~/.ironfish-simulator/simulations/{SIMULATION_RUN_ID} to store any simulation execution related files
  • clean up formatting for verbose node logs by providing a tag filterer
    • todo (address later if this becomes a problem): add tag filtering support to log handlers added after node creation

Closes IFL-661

Testing Plan

N/A

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@holahula holahula changed the base branch from master to staging May 8, 2023 16:30
@holahula holahula force-pushed the holahula/feat/simulator-cleanup branch from 2a8d1de to 2a44477 Compare May 8, 2023 16:34
@holahula holahula changed the title Holahula/feat/simulator cleanup fix(simulator): miscellaneous cleanup fixes May 8, 2023
@holahula holahula changed the title fix(simulator): miscellaneous cleanup fixes fix(simulator): miscellaneous cleanup fixes and improvements May 8, 2023
@holahula holahula force-pushed the holahula/feat/simulator-cleanup branch 3 times, most recently from 3fd3c88 to 5785be7 Compare May 8, 2023 17:59
@holahula holahula force-pushed the holahula/feat/simulator-cleanup branch from 5785be7 to a145861 Compare May 8, 2023 18:02
@holahula holahula marked this pull request as ready for review May 9, 2023 22:12
@holahula holahula requested a review from a team as a code owner May 9, 2023 22:12
@dguenther dguenther merged commit 7df802e into staging May 10, 2023
@dguenther dguenther deleted the holahula/feat/simulator-cleanup branch May 10, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants