Blstrs #3922
Merged
Blstrs #3922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason this changed is due to how bls12_381 and blstrs generate random Scalars
remove opencl dependency to minimize external system dependencies for now. we can investigate adding gpu support later, but expect most usage to be on cloud servers without access to gpus
mat-if
approved these changes
Jun 12, 2023
mat-if
added a commit
that referenced
this pull request
Jun 14, 2023
jowparks
pushed a commit
that referenced
this pull request
Jun 21, 2023
* WIP * Revert changes to transaction perf test * Revert changes to package.json * Revert transaction perf test fixture * Fix warnings * Update workflow * Try again * Format and clippy * update test due to change in scalar randomness The reason this changed is due to how bls12_381 and blstrs generate random Scalars * remove opencl dependency remove opencl dependency to minimize external system dependencies for now. we can investigate adding gpu support later, but expect most usage to be on cloud servers without access to gpus --------- Co-authored-by: Mat <mat@iflabs.network>
jowparks
pushed a commit
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.