Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop supporting .workerfile and Workerfile, use just .worker #104

Closed
romand opened this issue Jul 26, 2012 · 6 comments
Closed

stop supporting .workerfile and Workerfile, use just .worker #104

romand opened this issue Jul 26, 2012 · 6 comments

Comments

@romand
Copy link
Contributor

romand commented Jul 26, 2012

by numerous requests

@romand
Copy link
Contributor Author

romand commented Aug 9, 2012

@iced any objections?

@iced
Copy link
Contributor

iced commented Aug 17, 2012

Why to?

@treeder
Copy link
Contributor

treeder commented Aug 17, 2012

Because we don't support them.
On Aug 17, 2012 5:58 AM, "Andrew Kirilenko" notifications@github.com
wrote:

Why to?


Reply to this email directly or view it on GitHubhttps://github.com//issues/104#issuecomment-7817127.

@romand
Copy link
Contributor Author

romand commented Aug 17, 2012

.workerfile is just excessive alias for .worker, no use, little harm
But Workerfile introduces a lot of ambiguity:

  • is it executed if workerfile provided in constructor? if yes, before or after it?
  • is it executed, if name provided in constructor and .worker exists?
  • if name provided in Workerfile, is .worker executed?

IMHO Workerfile is error-prone and should be wiped out

@treeder
Copy link
Contributor

treeder commented Aug 20, 2012

+1

@iced
Copy link
Contributor

iced commented Sep 5, 2012

done

@iced iced closed this as completed Sep 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants