Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to delete schedules via cancel #232

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Allow to delete schedules via cancel #232

merged 1 commit into from
Jul 14, 2016

Conversation

pyeremenko
Copy link
Contributor

@pyeremenko pyeremenko commented Jul 14, 2016 •
edited
Loading

What this PR changes

It changes signature of schedules_cancel method by adding optional options parameter keeping method backward compatible.

Example

As of now it's possible to call this method as shown below:

worker_client.schedules_cancel(schedule_id, msg: 'cancelled because of my bad mood')
worker_client.schedules_cancel(schedule_id, delete: true)

@thousandsofthem thousandsofthem merged commit 01a0661 into master Jul 14, 2016
@thousandsofthem thousandsofthem deleted the iw-168-allow-to-delete-schedules-via-cancel branch July 14, 2016 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rkononov rkononov

@thousandsofthem thousandsofthem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyeremenko @rkononov @thousandsofthem